CCN-IN followup bugfix#99
Closed
grantfirl wants to merge 2 commits into
Closed
Conversation
…nd character length of Init_parm%fn_nml
…undant setting of NoahMP vars
Collaborator
|
Code is closed in #104, close PR. |
SamuelTrahanNOAA
referenced
this pull request
in SamuelTrahanNOAA/fv3atm
Jun 13, 2022
Testing Flake model with HRRR and GSD_v0 suites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following bug was discovered when propagating the MG CCN/IN changes to the CCPP SCM.
The variable iaerclm in the Model DDT (GFS_control_type) was conditionally initialized in GFS_typedefs.F90, leading to segmentation faults when the condition was not met (if the uninitialized variable somehow gets set to true by the compiler or an antecedent memory value).
Also, the character length of the fn_nml variable in the GFS_init_type DDT was different than other instances of the variable in the file. Changed the character length to 64 from 65 to be consistent. Credit to @pjpegion for finding this one.
In addition, two other minor bugfixes are included:
Model%debug is now initialized before use in GFS_typedefs.F90 and a redundant code block initializing variables for NoahMP was deleted.
This PR was initiated on the request of @climbfuji following successful CCPP SCM testing.