Address unreasonable large F0 and F1 in entrainment calculation#1033
Conversation
DusanJovic-NOAA
changed the title
|
@AnningCheng-NOAA Please list the ccpp/physics submodule dependency in the PR description |
|
@dusan Jovic - NOAA Affiliate ***@***.***> done. Please let me
know if you have any questions
…On Fri, Nov 14, 2025 at 9:14 AM Dusan Jovic ***@***.***> wrote:
*DusanJovic-NOAA* left a comment (NOAA-EMC/ufsatm#1033)
<#1033 (comment)>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> Please list the
ccpp/physics submodule dependency in the PR description
—
Reply to this email directly, view it on GitHub
<#1033 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIKILXJTASFE76VIGW334XPSRAVCNFSM6AAAAACLH32MBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMZSHE4TQNZWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
What is the ccpp/physics PR that this PR depends on? |
|
ufs-community/ccpp-physics#327
On Fri, Nov 14, 2025 at 9:29 AM Dusan Jovic ***@***.***>
wrote:
… *DusanJovic-NOAA* left a comment (NOAA-EMC/ufsatm#1033)
<#1033 (comment)>
@dusan <https://github.com/dusan> Jovic - NOAA Affiliate *@*.
*> done. Please let me know if you have any questions …
<#m_-247358175935697926_> On Fri, Nov 14, 2025 at 9:14 AM Dusan Jovic @.*>
wrote: *DusanJovic-NOAA* left a comment (NOAA-EMC/ufsatm#1033
<#1033>) <#1033 (comment)
<#1033 (comment)>>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>
https://github.com/AnningCheng-NOAA Please list the ccpp/physics
submodule dependency in the PR description — Reply to this email directly,
view it on GitHub <#1033 (comment)
<#1033 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALQPMIKILXJTASFE76VIGW334XPSRAVCNFSM6AAAAACLH32MBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMZSHE4TQNZWGM
. You are receiving this because you were mentioned.Message ID: *@*.***>
What is the ccpp/physics PR that this PR depends on?
—
Reply to this email directly, view it on GitHub
<#1033 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIKF5XL7TF2VYDN7MS334XRNLAVCNFSM6AAAAACLH32MBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMZTGA2TQOJSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Could we get review on this PR to prepare it's parent PR (WM #2971) for processing in the next couple days? |
|
yes. The reviewers: @JongilHan66, @BoYang-NOAA @XiaqiongZhou-NOAA @grantfirl @Qingfu-Liu |
The reviewers should actually review the ccpp/physics PR. This PR just updates ccpp/physics submodule hash. |
Yes, the CCPP PR has already been reviewed! |
|
@AnningCheng-NOAA Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@7e9ddf0) and revert the .gitmodules file in preparation for the merge. |
|
@rhaesung Kim - NOAA Affiliate ***@***.***> done
…On Fri, Nov 21, 2025 at 8:48 AM Rhae Sung Kim ***@***.***> wrote:
*rhaesung* left a comment (NOAA-EMC/ufsatm#1033)
<#1033 (comment)>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> Please update the
submodule pointer for ccpp-physics ***@***.***
<ufs-community/ccpp-physics@7e9ddf0>)
and revert the .gitmodules file in preparation for the merge.
—
Reply to this email directly, view it on GitHub
<#1033 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIKA66DIURUR2SQTJ7L354J3LAVCNFSM6AAAAACLH32MBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNRTGEYDCNRTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
7 participants
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
ursa
What compilers / HPCs was it tested with?
intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
yes. No new test
Have the ufs-weather-model regression test been run? On what platform?
yes. on ursa
whenever F0 > 3 and F1 >5.2 encountered.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs