Fix initialization of Atmos%iau_offset#1015
Merged
Merged
Conversation
22 tasks
Collaborator
|
Could we get this subcomponent PR reviewed so that it's ready to go when we begin to process high-priority WM PR #2913 in the next day or two? |
DusanJovic-NOAA
approved these changes
Sep 29, 2025
BrianCurtis-NOAA
approved these changes
Oct 2, 2025
Collaborator
|
Testing on #2913 is complete, please continue with merging, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the iau_offest was not being saved to Atmos%iau_offest. This bug resulted in the fixes introduced in #996 to not work as intended as discussed in NOAA-EMC/GFS#1 .
The change has been tested and seems to fix the issue with #996.
Issue(s) addressed
Testing
How were these changes tested? The entire RT suite was tested on Ursa.
What compilers / HPCs was it tested with? Both Intel and GNU
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? On what platform?
Full RT suite was run on Ursa. This only changes baselines on the v17 and GDAS RTs as expected.
Dependencies
None