Prate_avg fix (#979), UPP call freq and single restart var (#973) combo#996
Merged
jkbk2004 merged 5 commits intoAug 15, 2025
Merged
Conversation
14 tasks
Collaborator
|
all tests are done ok at ufs-community/ufs-weather-model#2836. this pr can be merged. |
jkbk2004
approved these changes
Aug 15, 2025
BrianCurtis-NOAA
approved these changes
Aug 15, 2025
| else | ||
| output_fh(1) = output_startfh | ||
| endif | ||
| output_fh(1) = output_startfh + dt_atmos/3600. |
Collaborator
There was a problem hiding this comment.
I don't understand...why output at dt_atmos/3600. regardless of what was requested?
Collaborator
Author
There was a problem hiding this comment.
I think that was to make the IAU output at the first time step anyways to be consistent with the cold start methodology.
#979 (comment)
This was referenced Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is combining #979 and part of #973. The fixes were originally developed by Jun Wang. This PR is just to combine these fixes and allow the changes to be added to the UFS PR queue.
#979 Fix zero accumulated total precip (Changes in baselines)
This PR is to resolve the issue with #976. The average total precipitation fields (accumulated from cycle starting time) are not correct in GFSv17 retro run.
The following code changes in production/GFS.16 were lost in the current fv3atm ccpp driver code: https://github.com/NOAA-EMC/fv3atm/blob/production/GFS.v16/gfsphysics/GFS_layer/GFS_driver.F90#L643-L649
ccpp_driver.F90 is updated with the code.
#973 Fix upp calling frequency when restart freq is not equal to history file freq (No baseline changes)
This PR is to fix the upp calling frequency when the restart output frequency and history file output frequency are not same. One example is in cpld_control_gfsv17_iau test, where the restart frequency is 3 while the history output frequency is 6. The inline post should only be called at the history output frequency, even when history files are written out (controlled by output_history).
#973 Allow marine components and fv3atm to use a single restart output time control variable (No baseline changes)
The marine and atm restart interval variables will now be based off of one variable. There will now be consistent restart times during the integration with and without IAU or restart from a certain forecast time.
Issue(s) addressed
PRs:
Testing
How were these changes tested? The UFS RT suite was run on Hercules
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? On what platform? The UFS RT suite was run on Hercules
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Do PRs in upstream repositories need to be merged first? No