Skip to content

Prate_avg fix (#979), UPP call freq and single restart var (#973) combo#996

Merged
jkbk2004 merged 5 commits into
NOAA-EMC:developfrom
dpsarmie:fix/Prate_avg-UPPCallFreq-combo
Aug 15, 2025
Merged

Prate_avg fix (#979), UPP call freq and single restart var (#973) combo#996
jkbk2004 merged 5 commits into
NOAA-EMC:developfrom
dpsarmie:fix/Prate_avg-UPPCallFreq-combo

Conversation

@dpsarmie
Copy link
Copy Markdown
Collaborator

@dpsarmie dpsarmie commented Jul 29, 2025

Description

This PR is combining #979 and part of #973. The fixes were originally developed by Jun Wang. This PR is just to combine these fixes and allow the changes to be added to the UFS PR queue.


#979 Fix zero accumulated total precip (Changes in baselines)

ccpp/CCPP_driver.F90
fv3/atmos_model.F90
fv3/fv3_cap.F90

This PR is to resolve the issue with #976. The average total precipitation fields (accumulated from cycle starting time) are not correct in GFSv17 retro run.

The following code changes in production/GFS.16 were lost in the current fv3atm ccpp driver code: https://github.com/NOAA-EMC/fv3atm/blob/production/GFS.v16/gfsphysics/GFS_layer/GFS_driver.F90#L643-L649

  if (Model%iau_offset > 0) then
      kdt_iau = nint(Model%iau_offset*con_hr/Model%dtp)
      if (Model%kdt == kdt_iau+1) then
        iauwindow_center = .true.
        do nb = 1,nblks
          call Diag(nb)%rad_zero  (Model)
          call Diag(nb)%phys_zero (Model,iauwindow_center=iauwindow_center)

ccpp_driver.F90 is updated with the code.


#973 Fix upp calling frequency when restart freq is not equal to history file freq (No baseline changes)

fv3/io/module_wrt_grid_comp.F90

This PR is to fix the upp calling frequency when the restart output frequency and history file output frequency are not same. One example is in cpld_control_gfsv17_iau test, where the restart frequency is 3 while the history output frequency is 6. The inline post should only be called at the history output frequency, even when history files are written out (controlled by output_history).


#973 Allow marine components and fv3atm to use a single restart output time control variable (No baseline changes)

fv3/module_fcst_grid_comp.F90

The marine and atm restart interval variables will now be based off of one variable. There will now be consistent restart times during the integration with and without IAU or restart from a certain forecast time.



Issue(s) addressed

PRs:

Testing

How were these changes tested? The UFS RT suite was run on Hercules
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? On what platform? The UFS RT suite was run on Hercules

  • Will the code updates change regression test baseline? Yes, the precipitation averaging change does change baselines

Dependencies

If testing this branch requires non-default branches in other repositories, list them.

Do PRs in upstream repositories need to be merged first? No

@dpsarmie dpsarmie changed the title Prate_avg fix (#979) and UPP call freq fix (part of #973) combo Prate_avg fix (#979), UPP call freq and single restart var (#973) combo Aug 5, 2025
@jkbk2004
Copy link
Copy Markdown
Collaborator

all tests are done ok at ufs-community/ufs-weather-model#2836. this pr can be merged.

@jkbk2004 jkbk2004 merged commit 40187b2 into NOAA-EMC:develop Aug 15, 2025
8 checks passed
Comment thread fv3/fv3_cap.F90
else
output_fh(1) = output_startfh
endif
output_fh(1) = output_startfh + dt_atmos/3600.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand...why output at dt_atmos/3600. regardless of what was requested?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was to make the IAU output at the first time step anyways to be consistent with the cold start methodology.
#979 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants