Replace icplocn2atm (integer) with use_oceanuv (logical)#1001
Merged
jkbk2004 merged 75 commits intoSep 17, 2025
Conversation
This reverts commit 491b5c6.
DusanJovic-NOAA
approved these changes
Sep 15, 2025
Collaborator
|
ufs-community/ccpp-physics#307 is merged, so this is ready to revert .gitmodules and update ccpp/physics |
jkbk2004
approved these changes
Sep 17, 2025
This was referenced Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the current integer option of icplocn2atm with a logical flag use_oceanuv
Issue(s) addressed
Testing
The only current UFS RT which utilizes the ocean surface currents in the ATM is B4B with this change.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs