Skip to content

ufs-community ccpp-physics 307#1164

Merged
grantfirl merged 13 commits into
NCAR:mainfrom
scrasmussen:ufsatm-1001
Sep 25, 2025
Merged

ufs-community ccpp-physics 307#1164
grantfirl merged 13 commits into
NCAR:mainfrom
scrasmussen:ufsatm-1001

Conversation

@scrasmussen
Copy link
Copy Markdown
Member

@scrasmussen scrasmussen commented Sep 18, 2025

Description of Changes:

Replaces current integer parameter icplocn2atm with logical flag use_oceanuv.

Relates PRs:

Documentation:

See Dependency PRs.

Dependencies

At least the following, maybe the newer ccpp-physics prs.

Issue (optional):

Fixes ufs-community/ufs-weather-model#2704

@grantfirl
Copy link
Copy Markdown
Collaborator

@scrasmussen It looks like there are more changes (100) in satmedmfvdifq.F in this PR than the original (82). Could you double-check this?

@grantfirl grantfirl requested a review from climbfuji September 24, 2025 19:50
Comment thread physics/SFC_Layer/UFS/sfc_diag.f Outdated
Comment thread physics/SFC_Layer/UFS/sfc_diff.f Outdated
Comment thread physics/SFC_Layer/UFS/sfc_nst.f90 Outdated
Comment thread physics/SFC_Models/Ocean/UFS/sfc_ocean.F Outdated
Comment thread physics/PBL/SATMEDMF/satmedmfvdifq.F Outdated
@grantfirl grantfirl requested a review from climbfuji September 25, 2025 17:49
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grantfirl !

@grantfirl grantfirl merged commit 5a43fea into NCAR:main Sep 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setting icplocn2atm should be renamed to clearly indicate its purpose

4 participants