Create JCB templates for marine B-matrix#36
Merged
Conversation
This was referenced Oct 23, 2024
DavidNew-NOAA
requested review from
AndrewEichmann-NOAA,
CoryMartin-NOAA,
danholdaway and
guillaumevernieres
danholdaway
reviewed
Oct 24, 2024
Collaborator
danholdaway
left a comment
danholdaway
left a comment
There was a problem hiding this comment.
Looks good. It might be good to modify the testing of marine in the main JCB repo to include these algorithms. There's an example of that for the atmosphere.
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
The 2 diffusion yamls are missing the "levels" key. I thought I modified in a previous prit but maybe not. I'll look into it later today.
danholdaway
approved these changes
Oct 30, 2024
guillaumevernieres
requested changes
Oct 30, 2024
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
Some updates are needed to the b-mat yaml, I'll look into it today.
Contributor
|
Sorry for the late review @DavidNew-NOAA . I went through the yamls and it's only a one liner change. |
Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
Contributor
Author
@danholdaway Can you point me to where specifically? Is these testing changes necessary before this PR is merged? |
guillaumevernieres
approved these changes
Nov 1, 2024
Collaborator
Contributor
Author
|
Thanks @danholdaway |
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Nov 6, 2024
This PR is a companion to Global Workflow PR [#2992](NOAA-EMC/global-workflow#2992) and JCB-GDAS PR [#36](NOAA-EMC/jcb-gdas#36). It makes a few necessary changes to the marine JCB base YAML required to have JCB working in the B-matrix task in the Global Workflow.
WalterKolczynski-NOAA
pushed a commit
to NOAA-EMC/global-workflow
that referenced
this pull request
Nov 19, 2024
…efactoring (#2992) This PR is a companion to GDASApp PR NOAA-EMC/GDASApp#1312 (merged) and NOAA-EMC/jcb-gdas#31 (merged). This PR does three things: 1. It changes the observation and bias staging for the atmospheric analysis tasks to use JCB templates instead of reading the full JEDI input configuration dictionary in order to construct a list of files to stage. This is cleaner and places fewer constraints on how to initialize the analysis. 2. The ```Jedi``` constructor now takes as input a dictionary that is essentially subset of the ```task_config``` dictionary. This makes the code clearer and less opaque and makes debugging easier. Each dictionary is constructed from a YAML file with configuration parameters for each JEDI application that is run. 3. All JEDI applications and their input YAMLs are now initialized in the initialize job of the ```AtmAnalysis``` and ```AtmEnsAnalysis```. Before, in the ```atmensanl*``` jobs for example, the LETKF solver was initialized in the ```atmensanlinit```cjob, but the LETKF solver and FV3 increment converter were both initialized and executed in the ```atmensanlobs``` and ```atmensanlfv3inc``` jobs respectively. This makes more sense in terms of resource allocation. Addendum: I'm now rolling in the refactoring of the marine B-matrix task into this PR. That makes it also a companion of NOAA-EMC/GDASApp#1346 and NOAA-EMC/jcb-gdas#36. These new changes introduce the ```Jedi``` class and JCB into the marine B-matrix job. Partially resolvesNOAA-EMC/GDASApp#1296 --------- Co-authored-by: RussTreadon-NOAA <Russ.Treadon@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
WalterKolczynski-NOAA
pushed a commit
to WalterKolczynski-NOAA/global-workflow
that referenced
this pull request
Nov 22, 2024
…efactoring (NOAA-EMC#2992) This PR is a companion to GDASApp PR NOAA-EMC/GDASApp#1312 (merged) and NOAA-EMC/jcb-gdas#31 (merged). This PR does three things: 1. It changes the observation and bias staging for the atmospheric analysis tasks to use JCB templates instead of reading the full JEDI input configuration dictionary in order to construct a list of files to stage. This is cleaner and places fewer constraints on how to initialize the analysis. 2. The ```Jedi``` constructor now takes as input a dictionary that is essentially subset of the ```task_config``` dictionary. This makes the code clearer and less opaque and makes debugging easier. Each dictionary is constructed from a YAML file with configuration parameters for each JEDI application that is run. 3. All JEDI applications and their input YAMLs are now initialized in the initialize job of the ```AtmAnalysis``` and ```AtmEnsAnalysis```. Before, in the ```atmensanl*``` jobs for example, the LETKF solver was initialized in the ```atmensanlinit```cjob, but the LETKF solver and FV3 increment converter were both initialized and executed in the ```atmensanlobs``` and ```atmensanlfv3inc``` jobs respectively. This makes more sense in terms of resource allocation. Addendum: I'm now rolling in the refactoring of the marine B-matrix task into this PR. That makes it also a companion of NOAA-EMC/GDASApp#1346 and NOAA-EMC/jcb-gdas#36. These new changes introduce the ```Jedi``` class and JCB into the marine B-matrix job. Partially resolvesNOAA-EMC/GDASApp#1296 --------- Co-authored-by: RussTreadon-NOAA <Russ.Treadon@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jul 23, 2025
…efactoring (#2992) This PR is a companion to GDASApp PR #1312 (merged) and NOAA-EMC/jcb-gdas#31 (merged). This PR does three things: 1. It changes the observation and bias staging for the atmospheric analysis tasks to use JCB templates instead of reading the full JEDI input configuration dictionary in order to construct a list of files to stage. This is cleaner and places fewer constraints on how to initialize the analysis. 2. The ```Jedi``` constructor now takes as input a dictionary that is essentially subset of the ```task_config``` dictionary. This makes the code clearer and less opaque and makes debugging easier. Each dictionary is constructed from a YAML file with configuration parameters for each JEDI application that is run. 3. All JEDI applications and their input YAMLs are now initialized in the initialize job of the ```AtmAnalysis``` and ```AtmEnsAnalysis```. Before, in the ```atmensanl*``` jobs for example, the LETKF solver was initialized in the ```atmensanlinit```cjob, but the LETKF solver and FV3 increment converter were both initialized and executed in the ```atmensanlobs``` and ```atmensanlfv3inc``` jobs respectively. This makes more sense in terms of resource allocation. Addendum: I'm now rolling in the refactoring of the marine B-matrix task into this PR. That makes it also a companion of #1346 and NOAA-EMC/jcb-gdas#36. These new changes introduce the ```Jedi``` class and JCB into the marine B-matrix job. Partially resolvesNOAA-EMC/GDASApp#1296 --------- Co-authored-by: RussTreadon-NOAA <Russ.Treadon@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 16, 2026
This PR is a companion to Global Workflow PR [#2992](NOAA-EMC/global-workflow#2992) and JCB-GDAS PR [#36](NOAA-EMC/jcb-gdas#36). It makes a few necessary changes to the marine JCB base YAML required to have JCB working in the B-matrix task in the Global Workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a companion to Global Workflow PR #2992 and GDASApp PR #1346.
It adds JCB templates for the input YAMLS of JEDI applications used in the marine B-matrix task in the Global Workflow.