JCB-based obs+bias staging#31
Merged
Merged
Conversation
This was referenced Oct 8, 2024
Contributor
|
@DavidNew-NOAA @danholdaway this is a good opportunity to figure out why the JCB-GDAS CI times out after hours. It hangs and doesn't work properly and I don't know what is going on (we can force merge like I was doing in Dan's absence) |
CoryMartin-NOAA
approved these changes
Oct 8, 2024
Contributor
|
@DavidNew-NOAA: As currently scripted all radiance bias correction files are in a single tarball. It sounds like aircraft bias correction will be a single file for all tail numbers. Is this correct, @CoryMartin-NOAA ? |
Contributor
|
@RussTreadon-NOAA that is my understanding, yes |
Contributor
Author
|
@CoryMartin-NOAA @RussTreadon-NOAA If that's the case, should we put an entry in each the observation templates, under the |
Contributor
|
@DavidNew-NOAA that might interfere with the JEDI YAML readers? |
Contributor
Author
|
@CoryMartin-NOAA See my latest commit. Also NOAA-EMC/GDASApp@29696c8 in my GDASApp PR. I think this is going to be the best way to do this. |
danholdaway
approved these changes
Oct 9, 2024
Collaborator
|
I can put it on my list for next week to fix the CI. I don't have a lot of time this week with the ongoing sprint and don't want to hold things up. |
CoryMartin-NOAA
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Oct 15, 2024
This PR is a companion to Global-Workflow PR [#2992](NOAA-EMC/global-workflow#2992) and JCB-GDAS PR [#31](NOAA-EMC/jcb-gdas#31). It adds two parameters required for the above Global-Workflow PR to the JCB base YAML for the atmosphere.
WalterKolczynski-NOAA
pushed a commit
to NOAA-EMC/global-workflow
that referenced
this pull request
Nov 19, 2024
…efactoring (#2992) This PR is a companion to GDASApp PR NOAA-EMC/GDASApp#1312 (merged) and NOAA-EMC/jcb-gdas#31 (merged). This PR does three things: 1. It changes the observation and bias staging for the atmospheric analysis tasks to use JCB templates instead of reading the full JEDI input configuration dictionary in order to construct a list of files to stage. This is cleaner and places fewer constraints on how to initialize the analysis. 2. The ```Jedi``` constructor now takes as input a dictionary that is essentially subset of the ```task_config``` dictionary. This makes the code clearer and less opaque and makes debugging easier. Each dictionary is constructed from a YAML file with configuration parameters for each JEDI application that is run. 3. All JEDI applications and their input YAMLs are now initialized in the initialize job of the ```AtmAnalysis``` and ```AtmEnsAnalysis```. Before, in the ```atmensanl*``` jobs for example, the LETKF solver was initialized in the ```atmensanlinit```cjob, but the LETKF solver and FV3 increment converter were both initialized and executed in the ```atmensanlobs``` and ```atmensanlfv3inc``` jobs respectively. This makes more sense in terms of resource allocation. Addendum: I'm now rolling in the refactoring of the marine B-matrix task into this PR. That makes it also a companion of NOAA-EMC/GDASApp#1346 and NOAA-EMC/jcb-gdas#36. These new changes introduce the ```Jedi``` class and JCB into the marine B-matrix job. Partially resolvesNOAA-EMC/GDASApp#1296 --------- Co-authored-by: RussTreadon-NOAA <Russ.Treadon@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
WalterKolczynski-NOAA
pushed a commit
to WalterKolczynski-NOAA/global-workflow
that referenced
this pull request
Nov 22, 2024
…efactoring (NOAA-EMC#2992) This PR is a companion to GDASApp PR NOAA-EMC/GDASApp#1312 (merged) and NOAA-EMC/jcb-gdas#31 (merged). This PR does three things: 1. It changes the observation and bias staging for the atmospheric analysis tasks to use JCB templates instead of reading the full JEDI input configuration dictionary in order to construct a list of files to stage. This is cleaner and places fewer constraints on how to initialize the analysis. 2. The ```Jedi``` constructor now takes as input a dictionary that is essentially subset of the ```task_config``` dictionary. This makes the code clearer and less opaque and makes debugging easier. Each dictionary is constructed from a YAML file with configuration parameters for each JEDI application that is run. 3. All JEDI applications and their input YAMLs are now initialized in the initialize job of the ```AtmAnalysis``` and ```AtmEnsAnalysis```. Before, in the ```atmensanl*``` jobs for example, the LETKF solver was initialized in the ```atmensanlinit```cjob, but the LETKF solver and FV3 increment converter were both initialized and executed in the ```atmensanlobs``` and ```atmensanlfv3inc``` jobs respectively. This makes more sense in terms of resource allocation. Addendum: I'm now rolling in the refactoring of the marine B-matrix task into this PR. That makes it also a companion of NOAA-EMC/GDASApp#1346 and NOAA-EMC/jcb-gdas#36. These new changes introduce the ```Jedi``` class and JCB into the marine B-matrix job. Partially resolvesNOAA-EMC/GDASApp#1296 --------- Co-authored-by: RussTreadon-NOAA <Russ.Treadon@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jul 23, 2025
…efactoring (#2992) This PR is a companion to GDASApp PR #1312 (merged) and NOAA-EMC/jcb-gdas#31 (merged). This PR does three things: 1. It changes the observation and bias staging for the atmospheric analysis tasks to use JCB templates instead of reading the full JEDI input configuration dictionary in order to construct a list of files to stage. This is cleaner and places fewer constraints on how to initialize the analysis. 2. The ```Jedi``` constructor now takes as input a dictionary that is essentially subset of the ```task_config``` dictionary. This makes the code clearer and less opaque and makes debugging easier. Each dictionary is constructed from a YAML file with configuration parameters for each JEDI application that is run. 3. All JEDI applications and their input YAMLs are now initialized in the initialize job of the ```AtmAnalysis``` and ```AtmEnsAnalysis```. Before, in the ```atmensanl*``` jobs for example, the LETKF solver was initialized in the ```atmensanlinit```cjob, but the LETKF solver and FV3 increment converter were both initialized and executed in the ```atmensanlobs``` and ```atmensanlfv3inc``` jobs respectively. This makes more sense in terms of resource allocation. Addendum: I'm now rolling in the refactoring of the marine B-matrix task into this PR. That makes it also a companion of #1346 and NOAA-EMC/jcb-gdas#36. These new changes introduce the ```Jedi``` class and JCB into the marine B-matrix job. Partially resolvesNOAA-EMC/GDASApp#1296 --------- Co-authored-by: RussTreadon-NOAA <Russ.Treadon@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 16, 2026
This PR is a companion to Global-Workflow PR [#2992](NOAA-EMC/global-workflow#2992) and JCB-GDAS PR [#31](NOAA-EMC/jcb-gdas#31). It adds two parameters required for the above Global-Workflow PR to the JCB base YAML for the atmosphere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a companion to Global Workflow PR #2992 and GDASApp PR #1312.
It add observation and bias files staging templates required for the above Global Workflow PR.