Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
7601bf0
Initial commit
DavidNew-NOAA Jun 11, 2025
0174f14
pynorms
DavidNew-NOAA Jun 11, 2025
ae46e1e
pynorms round 2
DavidNew-NOAA Jun 11, 2025
6759a3b
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jun 26, 2025
d12c536
Merge branch 'feature/marine-refactor' of https://github.com/DavidNew…
DavidNew-NOAA Jun 26, 2025
30aa61c
Update
DavidNew-NOAA Jun 26, 2025
9db049c
Update
DavidNew-NOAA Jun 26, 2025
778a7d3
Merge branch 'feature/marine-refactor' of https://github.com/DavidNew…
DavidNew-NOAA Jun 26, 2025
27c07f7
Update gdas hash
DavidNew-NOAA Jul 7, 2025
164159b
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jul 7, 2025
63eefd9
Debugging
DavidNew-NOAA Jul 9, 2025
1fe54d4
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jul 9, 2025
f013ae5
Update gdas hash
DavidNew-NOAA Jul 10, 2025
1453109
Refactor marine bmat finalize
DavidNew-NOAA Jul 10, 2025
78a87a6
Update gdas hash
DavidNew-NOAA Jul 10, 2025
b0d3c2c
Debugging
DavidNew-NOAA Jul 10, 2025
6e77d0a
Debugging
DavidNew-NOAA Jul 13, 2025
ab4cd24
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jul 13, 2025
3134e16
Update GDAS hash
DavidNew-NOAA Jul 14, 2025
7891b63
Updates
DavidNew-NOAA Jul 14, 2025
61e6eb8
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jul 14, 2025
7230339
pynorms
DavidNew-NOAA Jul 14, 2025
831b4af
Use vtscale spython script where it lives
DavidNew-NOAA Jul 14, 2025
8746086
Debugging
DavidNew-NOAA Jul 14, 2025
65d6f33
pynorms
DavidNew-NOAA Jul 14, 2025
d323050
Update gdas hash
DavidNew-NOAA Jul 17, 2025
57c1859
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jul 17, 2025
8481614
Update gdas hash
DavidNew-NOAA Jul 17, 2025
75dc235
Updates
DavidNew-NOAA Jul 18, 2025
c30580e
Update gdas hash
DavidNew-NOAA Jul 18, 2025
cf270f3
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jul 18, 2025
bc4f43f
change ocnanalecen to marineanlecen
DavidNew-NOAA Jul 21, 2025
e5f5828
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jul 21, 2025
2b372de
some ocnanalecen slipped through last commit
DavidNew-NOAA Jul 21, 2025
8694f3b
Update gdas hash
DavidNew-NOAA Jul 21, 2025
0510f72
Revert some things
DavidNew-NOAA Jul 21, 2025
05ade1b
Clean up
DavidNew-NOAA Jul 21, 2025
1aed6de
Update dev/parm/config/gfs/config.marineanlecen
DavidNew-NOAA Jul 22, 2025
7dd1745
Address reviewer comments
DavidNew-NOAA Jul 22, 2025
15e6027
Update gdas hash
DavidNew-NOAA Jul 22, 2025
d213ec9
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jul 25, 2025
15604ce
Update gdas hash
DavidNew-NOAA Jul 25, 2025
d05edc8
Update gdas hash to develop
DavidNew-NOAA Jul 25, 2025
567cbfe
Accidentally updated hera.yaml
DavidNew-NOAA Jul 25, 2025
18bf2a1
Missing config var
DavidNew-NOAA Jul 25, 2025
096d899
Fix archiving issue
DavidNew-NOAA Jul 28, 2025
758969e
Update gdas hash
DavidNew-NOAA Jul 28, 2025
01ecb58
Try something
DavidNew-NOAA Jul 29, 2025
50990d9
Merge branch 'develop' into feature/marine-refactor
DavidNew-NOAA Jul 29, 2025
ec7c3bd
Try something
DavidNew-NOAA Jul 29, 2025
1fcd437
apply patch
DavidNew-NOAA Jul 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ sorc/ocnicepost.fd
#------------------------------
# jobs symlinks
# scripts symlinks
scripts/exgdas_global_marine_analysis_ecen.py
scripts/exglobal_prep_ocean_obs.py
# ush symlinks
ush/bufr2ioda_insitu_profile_argo.py
Expand Down
4 changes: 2 additions & 2 deletions dev/jobs/ocnanalecen.sh → dev/jobs/marineanlecen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if [[ ${status} -ne 0 ]]; then
exit "${status}"
fi

export job="ocnanalecen"
export job="marineanlecen"
export jobid="${job}.$$"

###############################################################
Expand All @@ -20,6 +20,6 @@ export PYTHONPATH

###############################################################
# Execute the JJOB
"${HOMEgfs}"/jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN
"${HOMEgfs}"/jobs/JGLOBAL_MARINE_ANALYSIS_ECEN
status=$?
exit "${status}"
4 changes: 2 additions & 2 deletions dev/parm/config/gcafs/config.resources
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ if (( $# != 1 )); then
echo "waveinit waveprep wavepostsbs wavepostbndpnt wavepostbndpntbll wavepostpnt"
echo "wavegempak waveawipsbulls waveawipsgridded"
echo "postsnd awips gempak npoess"
echo "marineanlinit prepoceanobs marinebmat marineanlvar ocnanalecen marineanalletkf marineanlchkpt marineanlfinal ocnanalvrfy"
echo "marineanlinit prepoceanobs marinebmat marineanlvar marineanlecen marineanalletkf marineanlchkpt marineanlfinal ocnanalvrfy"
exit 1

fi
Expand Down Expand Up @@ -590,7 +590,7 @@ case ${step} in
tasks_per_node=$(( max_tasks_per_node / 2 ))
;;

"ocnanalecen")
"marineanlecen")
ntasks=16
case ${OCNRES} in
"025")
Expand Down
1 change: 0 additions & 1 deletion dev/parm/config/gfs/config.marineanl.j2
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

echo "BEGIN: config.marineanl"

export JEDI_CONFIG_YAML_BMAT="${PARMgfs}/gdas/soca_bmat_jedi_config.yaml.j2"
export JEDI_CONFIG_YAML_ANALYSIS="${PARMgfs}/gdas/soca_analysis_jedi_config.yaml.j2"
export JCB_ALGO_YAML_VAR="{{ JCB_ALGO_YAML_VAR }}"

Expand Down
15 changes: 15 additions & 0 deletions dev/parm/config/gfs/config.marineanlecen
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/bin/bash

########## config.marineanlecen ##########
# Ocn Analysis specific

echo "BEGIN: config.marineanlecen"

# Get task specific resources
source "${EXPDIR}/config.resources" marineanlecen

export JEDI_CONFIG_YAML_ECEN="${PARMgfs}/gdas/soca/soca_ecen_jedi_config.yaml.j2"
export MARINE_ECEN_STAGE_YAML_TMPL="${PARMgfs}/gdas/soca/soca_ecen_stage.yaml.j2"
export MARINE_ECEN_FINALIZE_YAML_TMPL="${PARMgfs}/gdas/soca/soca_ecen_finalize.yaml.j2"

echo "END: config.marineanlecen"
3 changes: 3 additions & 0 deletions dev/parm/config/gfs/config.marinebmat
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,7 @@ echo "BEGIN: config.marinebmat"
# Get task specific resources
. "${EXPDIR}/config.resources" marinebmat

export JEDI_CONFIG_YAML_BMAT="${PARMgfs}/gdas/soca_bmat_jedi_config.yaml.j2"
export MARINE_BMAT_FINALIZE_YAML_TMPL="${PARMgfs}/gdas/soca/soca_bmat_finalize.yaml.j2"

echo "END: config.marinebmat"
2 changes: 2 additions & 0 deletions dev/parm/config/gfs/config.marinebmatinit
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@ echo "BEGIN: config.marinebmatinit"
# Get task specific resources
source "${EXPDIR}/config.resources" marinebmatinit

export JEDI_CONFIG_YAML_BMAT="${PARMgfs}/gdas/soca_bmat_jedi_config.yaml.j2"

echo "END: config.marinebmatinit"
11 changes: 0 additions & 11 deletions dev/parm/config/gfs/config.ocnanalecen

This file was deleted.

4 changes: 2 additions & 2 deletions dev/parm/config/gfs/config.resources
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ if (( $# != 1 )); then
echo "waveinit waveprep wavepostsbs wavepostbndpnt wavepostbndpntbll wavepostpnt"
echo "wavegempak waveawipsbulls waveawipsgridded"
echo "postsnd awips gempak npoess"
echo "marineanlinit prepoceanobs marinebmatinit marinebmat marineanlvar ocnanalecen marineanalletkf marineanlchkpt marineanlfinal ocnanalvrfy"
echo "marineanlinit prepoceanobs marinebmatinit marinebmat marineanlvar marineanlecen marineanalletkf marineanlchkpt marineanlfinal ocnanalvrfy"
exit 1

fi
Expand Down Expand Up @@ -568,7 +568,7 @@ case ${step} in
tasks_per_node=$(( max_tasks_per_node / 2 ))
;;

"ocnanalecen")
"marineanlecen")
ntasks=16
walltime="00:10:00"
case ${OCNRES} in
Expand Down
2 changes: 1 addition & 1 deletion dev/parm/config/gfs/config.resources.GAEAC6
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ case ${step} in
esac
;;

"ocnanalecen")
"marineanlecen")
case ${OCNRES} in
"025")
ntasks=288
Expand Down
15 changes: 8 additions & 7 deletions dev/workflow/applications/gfs_cycled.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def _get_app_configs(self, run):
if options['do_letkf_ocn']:
configs += ['marineanlletkf']
if options['do_hybvar']:
configs += ['ocnanalecen']
configs += ['marineanlecen']
configs += ['marineanlchkpt', 'marineanlfinal']

if options['do_ocean'] or options['do_ice']:
Expand Down Expand Up @@ -255,12 +255,7 @@ def get_task_names(self):
task_names[run] += ['anal', 'analcalc']

if options['do_jediocnvar']:
task_names[run] += ['prepoceanobs', 'marineanlinit', 'marinebmatinit', 'marinebmat', 'marineanlvar']
if options['do_letkf_ocn']:
task_names[run] += ['marineanlletkf']
if options['do_hybvar']:
task_names[run] += ['ocnanalecen']
task_names[run] += ['marineanlchkpt', 'marineanlfinal']
task_names[run] += ['prepoceanobs', 'marineanlinit', 'marinebmatinit', 'marinebmat', 'marineanlvar', 'marineanlchkpt', 'marineanlfinal']

task_names[run] += ['sfcanl']

Expand Down Expand Up @@ -398,6 +393,12 @@ def get_task_names(self):
task_names[run].append('echgres') if 'gdas' in run else 0
task_names[run] += ['ediag']

if options['do_jediocnvar']:
if options['do_letkf_ocn']:
task_names[run] += ['marineanlletkf']
if options['do_hybvar']:
task_names[run] += ['marineanlecen']

task_names[run].append('esnowanl') if options['do_jedisnowda'] else 0
task_names[run].append('efcs') if 'gdas' in run else 0
task_names[run].append('epos') if 'gdas' in run else 0
Expand Down
8 changes: 4 additions & 4 deletions dev/workflow/build_opts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ build:
gfs_model:
command: "./build_ufs.sh -e gfs_model.x"
cores: 12
walltime: "00:30:00"
walltime: "00:40:00"

gfs_ww3prepost:
command: "./build_ww3prepost.sh"
Expand All @@ -46,7 +46,7 @@ build:
gefs_model:
command: "./build_ufs.sh -w -e gefs_model.x"
cores: 12
walltime: "00:30:00"
walltime: "00:40:00"

gefs_ww3_prepost:
command: "./build_ww3prepost.sh -w"
Expand All @@ -56,12 +56,12 @@ build:
sfs_model:
command: "./build_ufs.sh -y -e sfs_model.x"
cores: 12
walltime: "00:30:00"
walltime: "00:40:00"

gcafs_model:
command: "./build_ufs.sh -a ATMAERO -e gcafs_model.x"
cores: 12
walltime: "00:30:00"
walltime: "00:40:00"

upp:
command: "./build_upp.sh"
Expand Down
20 changes: 10 additions & 10 deletions dev/workflow/rocoto/gfs_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -707,9 +707,9 @@ def prepoceanobs(self):
def marineanlletkf(self):

deps = []
dep_dict = {'type': 'task', 'name': f'{self.run}_prepoceanobs'}
dep_dict = {'type': 'task', 'name': f"{self.run.replace('enkf','')}_prepoceanobs"}
deps.append(rocoto.add_dependency(dep_dict))
dep_dict = {'type': 'task', 'name': f'{self.run}_marinebmat'}
dep_dict = {'type': 'task', 'name': f"{self.run.replace('enkf','')}_marinebmat"}
deps.append(rocoto.add_dependency(dep_dict))
dependencies = rocoto.create_dependency(dep_condition='and', dep=deps)

Expand Down Expand Up @@ -836,22 +836,22 @@ def marineanlvar(self):

return task

def ocnanalecen(self):
def marineanlecen(self):

# can run in parallel with marinebmat
deps = []
dep_dict = {'type': 'task', 'name': f'{self.run}_marinebmatinit'}
dep_dict = {'type': 'task', 'name': f"{self.run.replace('enkf','')}_marinebmatinit"}
deps.append(rocoto.add_dependency(dep_dict))
dependencies = rocoto.create_dependency(dep=deps)

resources = self.get_resource('ocnanalecen')
task_name = f'{self.run}_ocnanalecen'
resources = self.get_resource('marineanlecen')
task_name = f'{self.run}_marineanlecen'
task_dict = {'task_name': task_name,
'resources': resources,
'dependency': dependencies,
'envars': self.envars,
'cycledef': self.run.replace('enkf', ''),
Comment thread
DavidNew-NOAA marked this conversation as resolved.
'command': f'{self.HOMEgfs}/dev/jobs/ocnanalecen.sh',
'command': f'{self.HOMEgfs}/dev/jobs/marineanlecen.sh',
'job_name': f'{self.pslot}_{task_name}_@H',
'log': f'{self.rotdir}/logs/@Y@m@d@H/{task_name}.log',
'maxtries': '&MAXTRIES;'
Expand All @@ -867,7 +867,7 @@ def marineanlchkpt(self):
dep_dict = {'type': 'task', 'name': f'{self.run}_marineanlvar'}
deps.append(rocoto.add_dependency(dep_dict))
if self.options['do_hybvar_ocn']:
dep_dict = {'type': 'task', 'name': f'{self.run}_ocnanalecen'}
dep_dict = {'type': 'task', 'name': f'enkf{self.run}_marineanlecen'}
Comment thread
DavidNew-NOAA marked this conversation as resolved.
deps.append(rocoto.add_dependency(dep_dict))
if self.options['do_mergensst']:
data = f'&ROTDIR;/{self.run}.@Y@m@d/@H/atmos/{self.run}.t@Hz.sfcanl.nc'
Expand Down Expand Up @@ -2809,7 +2809,7 @@ def efcs(self):
dep_dict = {'type': 'task', 'name': f'{self.run}_esfc'}
deps.append(rocoto.add_dependency(dep_dict))
if self.options['do_hybvar_ocn']:
dep_dict = {'type': 'task', 'name': f'{self.run.replace("enkf", "")}_ocnanalecen'}
dep_dict = {'type': 'task', 'name': f'{self.run}_marineanlecen'}
Comment thread
DavidNew-NOAA marked this conversation as resolved.
deps.append(rocoto.add_dependency(dep_dict))
dependencies = rocoto.create_dependency(dep_condition='and', dep=deps)
dep_dict = {'type': 'task', 'name': f'{self.run}_stage_ic'}
Expand Down Expand Up @@ -2993,7 +2993,7 @@ def earc_tars(self):
dep_dict = {'type': 'metatask', 'name': f'{self.run}_ecmn'}
deps.append(rocoto.add_dependency(dep_dict))
if self._base.get('DOHYBVAR_OCN', True):
dep_dict = {'type': 'task', 'name': f'gfs_ocnanalecen'}
dep_dict = {'type': 'task', 'name': f'enkfgfs_marineanlecen'}
Comment thread
DavidNew-NOAA marked this conversation as resolved.
deps.append(rocoto.add_dependency(dep_dict))
dep_dict = {'type': 'task', 'name': f'gfs_marineanlfinal'}
deps.append(rocoto.add_dependency(dep_dict))
Expand Down
2 changes: 1 addition & 1 deletion dev/workflow/rocoto/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Tasks:
'prepatmiodaobs', 'atmanlinit', 'atmanlvar', 'atmanlfv3inc', 'atmanlfinal',
'prep_emissions', 'prepoceanobs',
'marineanlinit', 'marineanlletkf', 'marinebmatinit', 'marinebmat', 'marineanlvar',
'ocnanalecen', 'marineanlchkpt', 'marineanlfinal', 'ocnanalvrfy',
'marineanlecen', 'marineanlchkpt', 'marineanlfinal', 'ocnanalvrfy',
'eobs', 'epos', 'esfc', 'eupd',
'earc_vrfy', 'earc_tars', 'ecen', 'echgres', 'ediag', 'efcs',
'atmensanlinit', 'atmensanlobs', 'atmensanlsol', 'atmensanlletkf', 'atmensanlfv3inc', 'atmensanlfinal', 'atmos_ensstat',
Expand Down
4 changes: 2 additions & 2 deletions env/GAEAC5.env
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ case ${step} in
export APRUNCFP="${launcher} -n \$ncmd ${mpmd_opt}"
export APRUN_MARINEANLVAR="${APRUN_default}"
;;
"ocnanalecen")
"marineanlecen")

export APRUN_OCNANALECEN="${APRUN_default}"
export APRUN_MARINEANLECEN="${APRUN_default}"
Comment thread
DavidNew-NOAA marked this conversation as resolved.
;;
"marineanlchkpt")

Expand Down
4 changes: 2 additions & 2 deletions env/GAEAC6.env
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ case ${step} in
export APRUNCFP="${launcher} -n \$ncmd ${mpmd_opt}"
export APRUN_MARINEANLVAR="${APRUN_default}"
;;
"ocnanalecen")
"marineanlecen")

export APRUN_OCNANALECEN="${APRUN_default}"
export APRUN_MARINEANLECEN="${APRUN_default}"
;;
"marineanlchkpt")

Expand Down
5 changes: 2 additions & 3 deletions env/HERA.env
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,9 @@ elif [[ "${step}" = "marineanlchkpt" ]]; then

export APRUN_MARINEANLOBSSTATS="${launcher} -n 1"

elif [[ "${step}" = "ocnanalecen" ]]; then
elif [[ "${step}" = "marineanlecen" ]]; then

export NTHREADS_OCNANALECEN=${NTHREADSmax}
export APRUN_OCNANALECEN="${APRUN_default} --cpus-per-task=${NTHREADS_OCNANALECEN}"
export APRUN_MARINEANLECEN=${APRUN_default}

elif [[ "${step}" = "marineanlletkf" ]]; then

Expand Down
4 changes: 2 additions & 2 deletions env/HERCULES.env
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ case ${step} in
export APRUNCFP="${launcher} -n \$ncmd ${mpmd_opt}"
export APRUN_MARINEANLVAR="${APRUN_default}"
;;
"ocnanalecen")
"marineanlecen")

export APRUN_OCNANALECEN="${APRUN_default}"
export APRUN_MARINEANLECEN="${APRUN_default}"
;;
"marineanlchkpt")

Expand Down
5 changes: 2 additions & 3 deletions env/ORION.env
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,9 @@ elif [[ "${step}" = "marineanlchkpt" ]]; then

export APRUN_MARINEANLOBSSTATS="${launcher} -n 1"

elif [[ "${step}" = "ocnanalecen" ]]; then
elif [[ "${step}" = "marineanlecen" ]]; then

export NTHREADS_OCNANALECEN=${NTHREADSmax}
export APRUN_OCNANALECEN="${APRUN_default} --cpus-per-task=${NTHREADS_OCNANALECEN}"
export APRUN_MARINEANLECEN=${APRUN_default}

elif [[ "${step}" = "marineanlletkf" ]]; then

Expand Down
6 changes: 3 additions & 3 deletions env/WCOSS2.env
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@ elif [[ "${step}" = "marineanlchkpt" ]]; then

export APRUN_MARINEANLOBSSTATS="${launcher} -n 1"

elif [[ "${step}" = "ocnanalecen" ]]; then
elif [[ "${step}" = "marineanlecen" ]]; then

export NTHREADS_OCNANALECEN=${NTHREADSmax}
export APRUN_OCNANALECEN="${APRUN_default}"
export NTHREADS_MARINEANLECEN=${NTHREADSmax}
export APRUN_MARINEANLECEN="${APRUN_default}"

elif [[ "${step}" = "marineanlletkf" ]]; then

Expand Down
4 changes: 2 additions & 2 deletions jobs/JGLOBAL_MARINE_ANALYSIS_CHECKPOINT
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/bin/bash
export WIPE_DATA="NO"
export DATAjob="${DATAROOT}/${RUN}marineanalysis.${PDY:-}${cyc}"
export DATAjob="${DATAROOT}/marineanalysis.${PDY:-}${cyc}"
export DATAens="${DATAjob}/ensdata"
export DATA="${DATAjob}/marinevariational"
export DATA="${DATAjob}/marineanlvar"
source "${HOMEgfs}/ush/jjob_header.sh" -e "marineanlchkpt" -c "base marineanl marineanlchkpt"


Expand Down
Loading