Skip to content

Update ufs-weather-model #3784

Merged
aerorahul merged 8 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:updatemodel20250606
Jun 12, 2025
Merged

Update ufs-weather-model #3784
aerorahul merged 8 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:updatemodel20250606

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Jun 9, 2025 •
edited
Loading

Description

This is an update of the ufs-weather-model (comparison diffs: ufs-community/ufs-weather-model@aba31a4...9193010). Which required a few parameters to be defined as parameters instead of constant values in the input.nml.

Additionally a minor bug fix in the GFSv17 ci tests for the /dev folder changes.

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.): Routine update of ufs-weather-model

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Ran generate_workflows on GaeaC6

tests passed except:
******** C96C48_hybatmsnowDA ********
202112201800 gdas_arch_tars 69757468 DEAD 15 2 15.0
202112210000 gdas_arch_tars 69758049 DEAD 15 2 18.0

which does not appear related to this PR.

[Updated] Otherwise all tests pass:

******** C48_ATM ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 09 2025 14:45:08    Jun 09 2025 16:30:05

******** C48mx500_3DVarAOWCDA ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Jun 09 2025 14:45:23    Jun 09 2025 15:45:09
202103250000        Done    Jun 09 2025 14:45:23    Jun 09 2025 17:15:05

******** C48mx500_hybAOWCDA ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Jun 09 2025 14:45:24    Jun 09 2025 16:00:10
202103250000        Done    Jun 09 2025 14:45:24    Jun 09 2025 17:10:06

******** C48_S2SW ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 09 2025 14:45:08    Jun 09 2025 16:45:40

******** C48_S2SWA_gefs ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 09 2025 14:45:07    Jun 09 2025 17:00:37

******** C96_atm3DVar ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Jun 09 2025 14:45:39    Jun 09 2025 15:40:40
202112210000        Done    Jun 09 2025 14:45:39    Jun 09 2025 18:10:19
202112210600        Done    Jun 09 2025 14:45:39    Jun 09 2025 17:55:07

******** C96C48_hybatmDA ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Jun 09 2025 14:45:07    Jun 09 2025 15:40:21
202112210000        Done    Jun 09 2025 14:45:07    Jun 09 2025 17:55:07
202112210600        Done    Jun 09 2025 14:45:07    Jun 09 2025 18:00:11

******** C96C48_hybatmsnowDA ********
202112201800          gdas_arch_tars                    69757468                DEAD                  15         2          15.0
202112210000          gdas_arch_tars                    69758049                DEAD                  15         2          18.0

******** C96C48mx500_S2SW_cyc_gfs ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Jun 09 2025 14:45:08    Jun 09 2025 16:00:10
202112201800        Done    Jun 09 2025 14:45:08    Jun 09 2025 18:10:55
202112210000        Done    Jun 09 2025 14:45:08    Jun 09 2025 19:05:05
202112211800        Done    Jun 09 2025 16:05:15    Jun 09 2025 18:55:14

******** C96mx100_S2S ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
199405010000        Done    Jun 09 2025 14:45:23    Jun 09 2025 16:50:21

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

aerorahul
aerorahul approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aerorahul aerorahul removed the request for review from WalterKolczynski-NOAA June 10, 2025 12:43
@aerorahul aerorahul added CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Jun 10, 2025
@KateFriedman-NOAA KateFriedman-NOAA added CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 and removed CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels Jun 10, 2025
KateFriedman-NOAA
KateFriedman-NOAA approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @JessicaMeixner-NOAA !

@KateFriedman-NOAA KateFriedman-NOAA added CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Jun 10, 2025
@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

KateFriedman-NOAA commented Jun 10, 2025

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3784/RUNTESTS on WCOSS

@emcbot emcbot added CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 labels Jun 10, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Jun 10, 2025

Experiment C96_gcafs_cycled FAILED on Gaeac6 in Build# 1 with error logs:

/gpfs/f6/drsa-precip3/world-shared/global/CI/3784/RUNTESTS/COMROOT/C96_gcafs_cycled_c524c2df/logs/2021122018/gcdas_fetch.log
/gpfs/f6/drsa-precip3/world-shared/global/CI/3784/RUNTESTS/COMROOT/C96_gcafs_cycled_c524c2df/logs/2021122100/gcdas_fetch.log

Follow link here to view the contents of the above file(s): (gcdas_fetch.log) (gcdas_fetch.log)

@emcbot emcbot added CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed and removed CI-Gaeac6-Running labels Jun 10, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Jun 10, 2025

Experiment C96_gcafs_cycled FAILED on Gaeac6 in Build# 1 in
/gpfs/f6/drsa-precip3/world-shared/global/CI/3784/RUNTESTS/EXPDIR/C96_gcafs_cycled_c524c2df

@emcbot emcbot removed the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Jun 11, 2025
@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

KateFriedman-NOAA commented Jun 11, 2025

WCOSS2 CI passed (minus known gempak failures):

Wed Jun 11 13:59:22 UTC 2025
******** C48_ATM_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 10 2025 14:20:15    Jun 10 2025 15:14:07

******** C48mx500_3DVarAOWCDA_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Jun 10 2025 14:20:17    Jun 10 2025 14:34:54
202103250000        Done    Jun 10 2025 14:20:17    Jun 10 2025 15:59:39

******** C48mx500_hybAOWCDA_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Jun 10 2025 14:20:19    Jun 10 2025 14:35:02
202103250000        Done    Jun 10 2025 14:20:19    Jun 10 2025 15:34:49

******** C48_S2SW_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 10 2025 14:20:21    Jun 10 2025 15:25:09

******** C48_S2SWA_gefs_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 10 2025 14:20:23    Jun 10 2025 15:30:05

******** C48_S2SW_extended_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 10 2025 14:20:26    Jun 10 2025 16:41:01
202103231800        Done    Jun 10 2025 14:20:26    Jun 10 2025 16:45:49

******** C96_atm3DVar_extended_3784 ********
202112211200    gfs_gempak_f147-f168                    45375263                DEAD                 -29         2        1854.0
202112211800    gfs_gempak_f123-f144                    45391989                DEAD                 -29         2        1855.0
202112211800    gfs_gempak_f147-f168                    45393071                DEAD                 -29         2        1851.0

******** C96C48_hybatmDA_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Jun 10 2025 14:20:33    Jun 10 2025 14:40:11
202112210000        Done    Jun 10 2025 14:20:33    Jun 10 2025 16:46:05
202112210600        Done    Jun 10 2025 14:20:33    Jun 10 2025 16:26:19

******** C96C48_hybatmsnowDA_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Jun 10 2025 14:20:35    Jun 10 2025 14:40:18
202112201800        Done    Jun 10 2025 14:20:35    Jun 10 2025 16:46:15
202112210000        Done    Jun 10 2025 14:20:35    Jun 10 2025 16:26:26

******** C96C48mx500_S2SW_cyc_gfs_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Jun 10 2025 14:20:38    Jun 10 2025 14:40:25
202112201800        Done    Jun 10 2025 14:20:38    Jun 10 2025 16:46:24
202112210000        Done    Jun 10 2025 14:20:38    Jun 10 2025 17:56:25
202112211800        Done    Jun 10 2025 14:45:40    Jun 10 2025 17:51:23

******** C96C48_ufs_hybatmDA_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202402231800        Done    Jun 10 2025 14:20:41    Jun 10 2025 14:40:33
202402240000        Done    Jun 10 2025 14:20:41    Jun 10 2025 17:16:45
202402240600        Done    Jun 10 2025 14:20:41    Jun 10 2025 17:01:44

******** C96_gcafs_cycled_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Jun 10 2025 14:20:45    Jun 10 2025 14:40:40
202112201800        Done    Jun 10 2025 14:20:45    Jun 10 2025 22:51:50
202112210000        Done    Jun 10 2025 14:20:45    Jun 10 2025 22:01:55

******** C96mx100_S2S_3784 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
199405010000        Done    Jun 10 2025 14:20:49    Jun 10 2025 15:56:11

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 and removed CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 labels Jun 11, 2025
@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 labels Jun 11, 2025
@KateFriedman-NOAA KateFriedman-NOAA added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Jun 11, 2025
@emcbot emcbot added CI-Gaeac6-Running and removed CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 labels Jun 11, 2025
@RuiyuSun
Copy link
Copy Markdown

RuiyuSun commented Jun 11, 2025 •
edited
Loading

@JessicaMeixner-NOAA Looks good. There will be a change with RF_CUTOFF =300 (instead of 100, which is current value) from @XiaqiongZhou-NOAA 's PR ufs-community/ufs-weather-model#2730

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Gaeac6-Running labels Jun 11, 2025
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Jun 12, 2025
Closed
@aerorahul aerorahul merged commit ff5476b into NOAA-EMC:develop Jun 12, 2025
5 checks passed
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jun 17, 2025
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the updatemodel20250606 branch June 26, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul aerorahul approved these changes

@bingfu-NOAA bingfu-NOAA bingfu-NOAA approved these changes

@junwang-noaa junwang-noaa Awaiting requested review from junwang-noaa

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA DavidHuber-NOAA is a code owner

+2 more reviewers

@NickSzapiro-NOAA NickSzapiro-NOAA NickSzapiro-NOAA left review comments

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JessicaMeixner-NOAA @KateFriedman-NOAA @emcbot @RuiyuSun @aerorahul @bingfu-NOAA @NickSzapiro-NOAA @TerrenceMcGuinness-NOAA