Skip to content

Save marine LETKF yaml #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidHuber-NOAA merged 5 commits into from
Jun 6, 2025
Merged

Save marine LETKF yaml #3489

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dcc0b6
Save marine LETKF yaml
Mar 23, 2025
f9310f2
Merge branch 'develop' into feature/save_marine_letkf_yaml
Jun 3, 2025
ad2a5da
Updates to save in COM_CONF and to archive
Jun 3, 2025
f4a74d7
add TODO
Jun 5, 2025
7696765
Merge branch 'develop' into feature/save_marine_letkf_yaml
DavidHuber-NOAA Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ush/python/pygfs/task/marine_letkf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def finalize(self):
keys = ['current_cycle', 'DATA', 'NMEM_ENS', 'WINDOW_BEGIN', 'GDUMP_ENS',
'PARMgfs', 'ROTDIR', 'COM_OCEAN_LETKF_TMPL', 'COM_ICE_LETKF_TMPL',
'COMOUT_OCEAN_LETKF', 'COMOUT_ICE_LETKF', 'WINDOW_MIDDLE',
'MARINE_OBS_LIST_YAML']
'MARINE_OBS_LIST_YAML', 'letkf_yaml_file']
for key in keys:
letkfsaveconf[key] = self.task_config[key]

Expand All @@ -205,5 +205,9 @@ def finalize(self):
# stage the desired diag files
FileHandler({'mkdir': [os.path.join(letkfsaveconf.COMOUT_OCEAN_LETKF, 'diags')]}).sync()
FileHandler({'copy': obs_files_to_copy}).sync()
# yaml configurations
yamls_to_copy = []
yamls_to_copy.append([letkfsaveconf.letkf_yaml_file, os.path.join(letkfsaveconf.COMOUT_OCEAN_LETKF, 'letkf.yaml')])

@aerorahul aerorahul Mar 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action is fine.
However, we are saving all the configurations to directory named COM_CONF instead of COMOUT_OCEAN_LETKF. COM_CONF is a directory in COM that has all the configurations of all the executables that are run in a cycle.

@shlyaeva shlyaeva Mar 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know this! I'll take a look later this week to change this and maybe also some other marine yamls that get copied to a different directory.

@shlyaeva shlyaeva Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally getting back to this. Is there a place where things from COM_CONF get archived? I haven't found it in the code yet. I'm wondering if I need a custom addition for archiving this yaml, or if it's already handled some place.

@aerorahul aerorahul Jun 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g.

global-workflow/parm/archive/gfsa.yaml.j2

Lines 14 to 15 in b1c60d4

# UFS configuration
- "{{ COMIN_CONF | relpath(ROTDIR) }}/ufs.input.nml"

shows that the gfsa.tar will contain the ufs.input.nml from COM_CONF.

@aerorahul aerorahul Jun 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A potential place to add this file to the archive list would be in this yaml.

FileHandler({'copy': yamls_to_copy}).sync()
letkf_save_list = parse_j2yaml(self.task_config.MARINE_LETKF_SAVE_YAML_TMPL, letkfsaveconf)
FileHandler(letkf_save_list).sync()