Save marine LETKF yaml#3489
Conversation
shlyaeva
requested review from
AndrewEichmann-NOAA and
guillaumevernieres
as code owners
| FileHandler({'copy': obs_files_to_copy}).sync() | ||
| # yaml configurations | ||
| yamls_to_copy = [] | ||
| yamls_to_copy.append([letkfsaveconf.letkf_yaml_file, os.path.join(letkfsaveconf.COMOUT_OCEAN_LETKF, 'letkf.yaml')]) |
There was a problem hiding this comment.
This action is fine.
However, we are saving all the configurations to directory named COM_CONF instead of COMOUT_OCEAN_LETKF. COM_CONF is a directory in COM that has all the configurations of all the executables that are run in a cycle.
There was a problem hiding this comment.
Nice, I didn't know this! I'll take a look later this week to change this and maybe also some other marine yamls that get copied to a different directory.
There was a problem hiding this comment.
Finally getting back to this. Is there a place where things from COM_CONF get archived? I haven't found it in the code yet. I'm wondering if I need a custom addition for archiving this yaml, or if it's already handled some place.
There was a problem hiding this comment.
E.g.
global-workflow/parm/archive/gfsa.yaml.j2
Lines 14 to 15 in b1c60d4
shows that the
gfsa.tar will contain the ufs.input.nml from COM_CONF.
There was a problem hiding this comment.
A potential place to add this file to the archive list would be in this yaml.
shlyaeva
dismissed stale reviews from guillaumevernieres and AndrewEichmann-NOAA
via
ad2a5da
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
Rest of the changes looks ok, but I have one comment that needs your attention.
aerorahul
added
the
CI-Gaeac6-Ready
emcbot
added
CI-Gaeac6-Building
| {% set tmpl_dict = ({ '${ROTDIR}':ROTDIR, | ||
| '${RUN}':RUN, | ||
| '${YMD}':cycle_YMD, | ||
| '${HH}':cycle_HH, | ||
| '${MEMDIR}': "ensstat"}) %} | ||
| {% set COMIN_CONF = COM_CONF_TMPL | replace_tmpl(tmpl_dict) %} |
There was a problem hiding this comment.
I think this should be moved to JGLOBAL_ENS_ARCHIVE_TARS by inserting a declaration here:
global-workflow/jobs/JGLOBAL_ENS_ARCHIVE_TARS
Lines 9 to 15 in e131fb1
But I'm OK with this being handled as part of #3767.
DavidHuber-NOAA
left a comment
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Approve with a note on a future change request for the COMIN_CONF declaration in master_enkf.yaml.j2 to be moved to JGLOBAL_ENS_ARCHIVE_TARS.
7 participants
Description
Saves marine LETKF yaml for posterity and for EVA verifications plots.
Note: this is not urgent as it's not required for v17.
Type of change
Change characteristics
How has this been tested?
Tested with the hybrid C384m025 experiment in ci/cases/gfsv17, with hera/intel. The yaml is saved in COMROOT as expected and successfully used for diagnostics plots (see NOAA-EMC/gdas-marine-viz#511 for an example).
Checklist