Skip to content

Bug fix to the failing early cycle marine DA ensemble re-centering #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aerorahul merged 6 commits into from
Mar 20, 2025
Merged

Bug fix to the failing early cycle marine DA ensemble re-centering #3454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
815f0f1
fixed ocn recentering for the gfs cycle, need tidy
guillaumevernieres Mar 14, 2025
c0f926d
Merge branch 'develop' into bugfix/ocn_ecen
guillaumevernieres Mar 17, 2025
0f92b2b
removed early cycle
guillaumevernieres Mar 19, 2025
cf4a0be
Merge branch 'develop' into bugfix/ocn_ecen
guillaumevernieres Mar 19, 2025
9fe79f5
Merge branch 'develop' into bugfix/ocn_ecen
guillaumevernieres Mar 19, 2025
d6f74d7
updated gdas #
guillaumevernieres Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/bin/bash
source "${HOMEgfs}/ush/preamble.sh"

export DATAjob="${DATAROOT}/${RUN}marineanalysis.${PDY:-}${cyc}"
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note here, but PDY will not be defined here when we go to ops. It comes from setPDY called in jjob_header.sh.
We will have some work to do here, but its fine for now.

export DATA="${DATAjob}/${jobid}"
export DATAens="${DATAjob}/ensdata"

source "${HOMEgfs}/ush/jjob_header.sh" -e "ocnanalecen" -c "base marineanl ocnanalecen"

##############################################
Expand All @@ -10,21 +15,22 @@ source "${HOMEgfs}/ush/jjob_header.sh" -e "ocnanalecen" -c "base marineanl ocnan
GDATE=$(date --utc +%Y%m%d%H -d "${PDY} ${cyc} - ${assim_freq} hours")
export gPDY=${GDATE:0:8}
export gcyc=${GDATE:8:2}
export GDUMP="gdas"
export GDUMP_ENS="enkf${GDUMP}"

YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx \
RUN=${GDUMP} YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx \
COMIN_OCEAN_HISTORY_PREV:COM_OCEAN_HISTORY_TMPL \
COMIN_ICE_HISTORY_PREV:COM_ICE_HISTORY_TMPL

RUN=${GDUMP_ENS} YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx \
COMIN_OCEAN_HISTORY_ENS_PREV:COM_OCEAN_HISTORY_TMPL \
COMIN_ICE_HISTORY_ENS_PREV:COM_ICE_HISTORY_TMPL

YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \
COMOUT_OCEAN_ANALYSIS:COM_OCEAN_ANALYSIS_TMPL \
COMIN_ICE_RESTART:COM_ICE_RESTART_TMPL \
COMOUT_ICE_ANALYSIS:COM_ICE_ANALYSIS_TMPL

export DATAjob="${DATAROOT}/${RUN}marineanalysis.${PDY:-}${cyc}"
export DATAens="${DATAjob}/ensdata"
export GDUMP="gdas"
export GDUMP_ENS="enkf${GDUMP}"

##############################################
# Begin JOB SPECIFIC work
##############################################
Expand Down
2 changes: 1 addition & 1 deletion sorc/gdas.cd
Open in desktop
Submodule gdas.cd updated 18 files
+11 −6 ci/run_ci.sh
+1 −1 parm/jcb-algorithms
+1 −1 parm/jcb-gdas
+7 −0 parm/soca/obs/config/sss_smap_l2.yaml
+7 −0 parm/soca/obs/config/sss_smos_l2.yaml
+22 −0 parm/stat/aero/jcb-base.yaml.j2
+22 −0 parm/stat/atmos/jcb-base.yaml.j2
+22 −0 parm/stat/snow/jcb-base.yaml.j2
+1 −1 sorc/fv3-jedi
+1 −1 sorc/iodaconv
+1 −1 sorc/oops
+1 −1 sorc/saber
+1 −1 sorc/soca
+1 −1 sorc/ufo
+1 −1 sorc/vader
+1 −1 test/gw-ci/create_exp.sh
+5 −19 ush/soca/marine_recenter.py
+4 −7 utils/soca/gdas_ens_handler.h