Skip to content

Update aerosol climatology to 2013-2024 mean#2888

Merged
WalterKolczynski-NOAA merged 3 commits into
NOAA-EMC:developfrom
AnningCheng-NOAA:mr2_24clmt
Sep 6, 2024
Merged

Update aerosol climatology to 2013-2024 mean#2888
WalterKolczynski-NOAA merged 3 commits into
NOAA-EMC:developfrom
AnningCheng-NOAA:mr2_24clmt

Conversation

@AnningCheng-NOAA
Copy link
Copy Markdown
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Sep 4, 2024

Description

use the updated 2013 to 2024 mean MERRA2 climatology instead of 2003 to 2014 mean

Depends on #2887
Refs: ufs-community/ufs-weather-model#2272
Refs: ufs-community/ufs-weather-model#2273

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • [X ] Any dependent changes have been merged and published
  • [ X] My code follows the style guidelines of this project
  • [X ] I have performed a self-review of my own code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [X ] My changes generate no new warnings
  • [X ] New and existing tests pass with my changes
  • [X ] I have made corresponding changes to the documentation if necessary

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the blocked Issue is currently being blocked by another issue. Include blocking issue # in description label Sep 4, 2024
@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor

Hold CI testing until #2887 is completed

@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor

Is a model update actually required? I don't think the changes here depend on the model regression tests being updated.

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title link aer using the 2013-2024 mean MERRA2 climatology Update aerosol climatology to 2013-2024 mean Sep 4, 2024
@AnningCheng-NOAA
Copy link
Copy Markdown
Contributor Author

AnningCheng-NOAA commented Sep 4, 2024 via email

Copy link
Copy Markdown
Contributor

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #2887 is addressed, this PR will need an update to point to the new fix/aer timestamp. Otherwise, looks good.

NeilBarton-NOAA
NeilBarton-NOAA previously approved these changes Sep 4, 2024
@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor

Once #2887 is addressed, this PR will need an update to point to the new fix/aer timestamp. Otherwise, looks good.

#2887 is adding files, not replacing files, so no version increment should be needed.

@CatherineThomas-NOAA
Copy link
Copy Markdown
Contributor

#2887 is adding files, not replacing files, so no version increment should be needed.

Good point @WalterKolczynski-NOAA. Thanks.

Comment thread ush/forecast_predet.sh Outdated
@AnningCheng-NOAA
Copy link
Copy Markdown
Contributor Author

AnningCheng-NOAA commented Sep 5, 2024 via email

@WalterKolczynski-NOAA WalterKolczynski-NOAA dismissed stale reviews from NeilBarton-NOAA and themself via 4b82a06 September 5, 2024 17:49
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed blocked Issue is currently being blocked by another issue. Include blocking issue # in description labels Sep 5, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Sep 5, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Sep 6, 2024

CI Passed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/2888


Experiment C48_ATM_2be556a6 Completed 1 Cycles: *SUCCESS* at Thu Sep  5 23:06:32 UTC 2024
Experiment C48mx500_3DVarAOWCDA_2be556a6 Completed 2 Cycles: *SUCCESS* at Thu Sep  5 23:12:39 UTC 2024
Experiment C96C48_hybatmDA_2be556a6 Completed 3 Cycles: *SUCCESS* at Fri Sep  6 00:14:36 UTC 2024
Experiment C96_atm3DVar_2be556a6 Completed 3 Cycles: *SUCCESS* at Fri Sep  6 00:20:34 UTC 2024
Experiment C96C48_ufs_hybatmDA_2be556a6 Completed 2 Cycles: *SUCCESS* at Fri Sep  6 00:45:47 UTC 2024
Experiment C48_S2SWA_gefs_2be556a6 Completed 1 Cycles: *SUCCESS* at Fri Sep  6 00:46:04 UTC 2024
Experiment C48_S2SW_2be556a6 Completed 1 Cycles: *SUCCESS* at Fri Sep  6 00:57:46 UTC 2024
Experiment C96C48_hybatmaerosnowDA_2be556a6 Completed 3 Cycles: *SUCCESS* at Fri Sep  6 01:28:33 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels Sep 6, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels Sep 6, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Sep 6, 2024

CI Update on Wcoss2 at 09/06/24 01:32:10 AM
============================================
Cloning and Building global-workflow PR: 2888
with PID: 20029 on host: dlogin03

@emcbot emcbot added CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Sep 6, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Sep 6, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Fri Sep  6 01:35:21 UTC 2024 on dlogin03
---------------------------------------------------
Build: Completed at 09/06/24 02:12:13 AM
Case setup: Completed for experiment C48_ATM_2be556a6
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_2be556a6
Case setup: Skipped for experiment C48_S2SWA_gefs_2be556a6
Case setup: Completed for experiment C48_S2SW_2be556a6
Case setup: Completed for experiment C96_atm3DVar_extended_2be556a6
Case setup: Skipped for experiment C96_atm3DVar_2be556a6
Case setup: Completed for experiment C96C48_hybatmaerosnowDA_2be556a6
Case setup: Completed for experiment C96C48_hybatmDA_2be556a6
Case setup: Completed for experiment C96C48_ufs_hybatmDA_2be556a6

@emcbot emcbot added CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Sep 6, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Sep 6, 2024

CI Passed on Hercules in Build# 2
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2888


Experiment C48_ATM_2be556a6 Completed 1 Cycles: *SUCCESS* at Thu Sep  5 22:51:16 CDT 2024
Experiment C96_atm3DVar_2be556a6 Completed 3 Cycles: *SUCCESS* at Thu Sep  5 23:57:48 CDT 2024
Experiment C96C48_hybatmDA_2be556a6 Completed 3 Cycles: *SUCCESS* at Thu Sep  5 23:57:51 CDT 2024
Experiment C48_S2SW_2be556a6 Completed 1 Cycles: *SUCCESS* at Fri Sep  6 00:22:04 CDT 2024
Experiment C48_S2SWA_gefs_2be556a6 Completed 1 Cycles: *SUCCESS* at Fri Sep  6 01:11:04 CDT 2024

@emcbot emcbot added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Sep 6, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Sep 6, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_2be556a6 *** SUCCESS *** at 09/06/24 03:36:12 AM
Experiment C48_S2SW_2be556a6 *** SUCCESS *** at 09/06/24 03:48:13 AM
Experiment C96C48_hybatmDA_2be556a6 *** SUCCESS *** at 09/06/24 04:42:31 AM
Experiment C96C48_hybatmaerosnowDA_2be556a6 *** SUCCESS *** at 09/06/24 05:36:30 AM
Experiment C96C48_ufs_hybatmDA_2be556a6 *** SUCCESS *** at 09/06/24 06:27:20 AM
Experiment C96_atm3DVar_extended_2be556a6 *** SUCCESS *** at 09/06/24 03:21:50 PM

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit d3ea8e2 into NOAA-EMC:develop Sep 6, 2024
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Sep 9, 2024
* origin/develop:
  Create JEDI class (NOAA-EMC#2805)
  Restructure the bufr sounding job    (NOAA-EMC#2853)
  Add an archive task to GEFS system to archive files locally (NOAA-EMC#2816)
  Reenable Orion Cycling Support (NOAA-EMC#2877)
  Eliminate race conditions and remove DATAROOT last in cleanup (NOAA-EMC#2893)
  Update aerosol climatology to 2013-2024 mean (NOAA-EMC#2888)
  Add ability to run CI test C96_atm3DVar.yaml to Gaea-C5 (NOAA-EMC#2885)
  Support global-workflow GEFS C48 on Google Cloud (NOAA-EMC#2861)
  Add 3 and 9 hr increment files to IC staging (NOAA-EMC#2876)
  Add diffusion/diag B for aerosol DA and some other needed changes (NOAA-EMC#2738)
  Correct ocean `MOM.res_#` stage copy (NOAA-EMC#2868)
  Support coupling on AWS (NOAA-EMC#2859)
  Add JEDI ATM lgetkf observer and solver jobs (NOAA-EMC#2833)
  Fix gdas build on Gaea and add Gaea to available CI list (NOAA-EMC#2857)
  Support ATM forecast only on Google (NOAA-EMC#2832)
  Add GEFS C48 support on AWS (NOAA-EMC#2818)
  Update omega calculation (NOAA-EMC#2751)
  Add snow DA update and recentering for the EnKF forecasts (NOAA-EMC#2690)
  support ATM forecast only on Azure (NOAA-EMC#2827)
  Convert staging job to python and yaml (NOAA-EMC#2651)
  Fixed test on UNAVAILBLE in python Rocoto check (NOAA-EMC#2842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants