Check that a PR driver is still running before trying to kill it#2799
Merged
WalterKolczynski-NOAA merged 8 commits intoAug 7, 2024
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
DavidHuber-NOAA
changed the title
WalterKolczynski-NOAA
previously approved these changes
Jul 30, 2024
Contributor
WalterKolczynski-NOAA
left a comment
WalterKolczynski-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me, but hold for @TerrenceMcGuinness-NOAA to get back and review it.
Contributor
|
@TerrenceMcGuinness-NOAA Please review this so it can move forward. |
TerrenceMcGuinness-NOAA
requested changes
Aug 6, 2024
TerrenceMcGuinness-NOAA
approved these changes
Aug 7, 2024
Collaborator
TerrenceMcGuinness-NOAA
left a comment
TerrenceMcGuinness-NOAA
left a comment
There was a problem hiding this comment.
Nice updates.
CoryMartin-NOAA
pushed a commit
to CoryMartin-NOAA/global-workflow
that referenced
this pull request
Aug 7, 2024
…A-EMC#2799) Adds a check to the SSH command used to kill child PIDs of a defunct driver instance on a different head node to prevent invalid kill commands, preventing CI failures. Resolves NOAA-EMC#2798
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/global-workflow
that referenced
this pull request
Aug 9, 2024
* origin/develop: Stage atmospheric backgrounds and UFS cubed-sphere history files (NOAA-EMC#2792) Check that a PR driver is still running before trying to kill it (NOAA-EMC#2799) Feature/get arch adds an empty archive job to GEFS system (NOAA-EMC#2772) Marine DA updates (NOAA-EMC#2802) Revert MSU FIX_DIRs back to glopara (NOAA-EMC#2811) Bugfix for updating label states in Jenkins (NOAA-EMC#2808) Clean-up temporary rundirs - take 2. (NOAA-EMC#2753) Change land surface for HR4 (NOAA-EMC#2787) Run METplus serially and correct the name of prod tasks (NOAA-EMC#2804) Update Java Agent launching script for Jenkins connections (NOAA-EMC#2762) Fix erroneous cdump addition (NOAA-EMC#2803) Update ocean post-processing triggers (NOAA-EMC#2784) Update the gfs_utils repository hash (NOAA-EMC#2801) Add fixes for metplus jobs when gfs_cyc=2 or 4 (NOAA-EMC#2791) Simplify resource-related variables, remove CDUMP where unneeded (NOAA-EMC#2727) Remove f000 from atmos rocoto tasks for replay cases (NOAA-EMC#2778)
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/global-workflow
that referenced
this pull request
Aug 9, 2024
* origin/develop: Stage atmospheric backgrounds and UFS cubed-sphere history files (NOAA-EMC#2792) Check that a PR driver is still running before trying to kill it (NOAA-EMC#2799) Feature/get arch adds an empty archive job to GEFS system (NOAA-EMC#2772) Marine DA updates (NOAA-EMC#2802) Revert MSU FIX_DIRs back to glopara (NOAA-EMC#2811) Bugfix for updating label states in Jenkins (NOAA-EMC#2808) Clean-up temporary rundirs - take 2. (NOAA-EMC#2753) Change land surface for HR4 (NOAA-EMC#2787) Run METplus serially and correct the name of prod tasks (NOAA-EMC#2804) Update Java Agent launching script for Jenkins connections (NOAA-EMC#2762) Fix erroneous cdump addition (NOAA-EMC#2803) Update ocean post-processing triggers (NOAA-EMC#2784) Update the gfs_utils repository hash (NOAA-EMC#2801) Add fixes for metplus jobs when gfs_cyc=2 or 4 (NOAA-EMC#2791) Simplify resource-related variables, remove CDUMP where unneeded (NOAA-EMC#2727) Remove f000 from atmos rocoto tasks for replay cases (NOAA-EMC#2778)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a check to the SSH command used to kill child PIDs of a defunct driver instance on a different head node to prevent invalid kill commands, preventing CI failures.
Resolves #2798
Type of change
Change characteristics
How has this been tested?
Successfully detected the driver was no longer running on WCOSS2 for PR #2791.
Checklist