Feature/get arch adds an empty archive job to GEFS system by AntonMFernando-NOAA · Pull Request #2772 · NOAA-EMC/global-workflow

AntonMFernando-NOAA · 2024-07-17T15:27:53Z

Description

This feature added an archive task for GEFS system. This task will run in the service queue with a single processor.
The task executes with success.
Only xml is generated.

Resolves #
Refs #832 #2698
Refs NOAA-EMC/repo#

Type of change

New feature (adds functionality)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

Forecast-only on Hercules

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

/config.resources

…sks.py

aerorahul

A few comments that need attention.

…fs_tasks.py

…NOAA/global-workflow into feature/get-arch

AntonMFernando-NOAA · 2024-08-06T16:25:37Z

@AntonMFernando-NOAA arch_test.sh doesn't appear to have executable permissions.

@WalterKolczynski-NOAA I think I fixed it. However, permission change to a file cannot be added as a commit in git. Please check whether the ci test passes.

WalterKolczynski-NOAA · 2024-08-06T16:31:06Z

@AntonMFernando-NOAA arch_test.sh doesn't appear to have executable permissions.

@WalterKolczynski-NOAA I think I fixed it. However, permission change to a file cannot be added as a commit in git. Please check whether the ci test passes.

You should be able to.

DavidHuber-NOAA · 2024-08-06T16:40:27Z

@AntonMFernando-NOAA The mode still is not executable. This worked for me:

> cd jobs/rocoto
> chmod +x arch_test.sh
> git diff arch_test.sh
diff --git a/jobs/rocoto/arch_test.sh b/jobs/rocoto/arch_test.sh
old mode 100644
new mode 100755
> git commit arch_test.sh "Make arch_test.sh executable"

AntonMFernando-NOAA · 2024-08-06T17:57:08Z

@AntonMFernando-NOAA The mode still is not executable. This worked for me:

> cd jobs/rocoto
> chmod +x arch_test.sh
> git diff arch_test.sh
diff --git a/jobs/rocoto/arch_test.sh b/jobs/rocoto/arch_test.sh
old mode 100644
new mode 100755
> git commit arch_test.sh "Make arch_test.sh executable"

@WalterKolczynski-NOAA @DavidHuber-NOAA Good to go now.

emcbot · 2024-08-06T23:08:12Z

CI Passed Hercules at
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2772


Experiment C48_ATM_6fb6cbfc Completed 1 Cycles: *SUCCESS* at Tue Aug  6 15:17:10 CDT 2024
Experiment C96_atm3DVar_6fb6cbfc Completed 3 Cycles: *SUCCESS* at Tue Aug  6 17:31:01 CDT 2024
Experiment C48_S2SW_6fb6cbfc Completed 1 Cycles: *SUCCESS* at Tue Aug  6 17:43:26 CDT 2024
Experiment C96C48_hybatmDA_6fb6cbfc Completed 3 Cycles: *SUCCESS* at Tue Aug  6 17:43:26 CDT 2024
Experiment C48_S2SWA_gefs_6fb6cbfc Completed 1 Cycles: *SUCCESS* at Tue Aug  6 18:07:59 CDT 2024

) - This feature added an archive task for GEFS system. This task will run in the service queue with a single processor. The task executes with success. - Only xml is generated. Refs NOAA-EMC#832 Refs NOAA-EMC#2698

* origin/develop: Stage atmospheric backgrounds and UFS cubed-sphere history files (NOAA-EMC#2792) Check that a PR driver is still running before trying to kill it (NOAA-EMC#2799) Feature/get arch adds an empty archive job to GEFS system (NOAA-EMC#2772) Marine DA updates (NOAA-EMC#2802) Revert MSU FIX_DIRs back to glopara (NOAA-EMC#2811) Bugfix for updating label states in Jenkins (NOAA-EMC#2808) Clean-up temporary rundirs - take 2. (NOAA-EMC#2753) Change land surface for HR4 (NOAA-EMC#2787) Run METplus serially and correct the name of prod tasks (NOAA-EMC#2804) Update Java Agent launching script for Jenkins connections (NOAA-EMC#2762) Fix erroneous cdump addition (NOAA-EMC#2803) Update ocean post-processing triggers (NOAA-EMC#2784) Update the gfs_utils repository hash (NOAA-EMC#2801) Add fixes for metplus jobs when gfs_cyc=2 or 4 (NOAA-EMC#2791) Simplify resource-related variables, remove CDUMP where unneeded (NOAA-EMC#2727) Remove f000 from atmos rocoto tasks for replay cases (NOAA-EMC#2778)

- This task is an extension of the empty arch job previously merged. - This feature adds an archive task to GEFS system to archive files locally. - This feature archives files in ensstat directory. Resolves #2698 Refs #832 #2772

- This task is an extension of the arch job previously merged that archives files in ROTDIR (#2816 AntonMFernando-NOAA@2816c3b) - This feature adds an archive task to GEFS system to archive files in HPSSARCH and LOCALARCH. Resolves #2698 Refs #2816 #2772 #832 --------- Co-authored-by: David Huber <david.huber@noaa.gov>

…C#2772) * UFSWM - Update default_vars and tests so that LSM 1/2 sets LANDICE true/false appropriately.

AntonMFernando-NOAA added 11 commits July 16, 2024 16:59

added an arch_test.sh to global-workflow/jobs/rocoto

5f444c9

Added config.arch file to global-workflow/parm/config/gefs

b81155e

modified global-workflow/parm/config/gefs

9262051

/config.resources

modified workflow/applications/gefs.py

50fc7d8

modified global-workflow/workflow/rocoto/gefs_tasks.py

976a7dd

modified (removed blank line) global-workflow/workflow/rocoto/gefs_ta…

566b851

…sks.py

modified modified global-workflow/workflow/rocoto/gefs_tasks.py

a13a53a

added arch_test.sh to global-workflow/jobs/rocoto

c999ed4

removed arch_test.sh (error)

084be61

added arch_test.sh

2f2ed22

modified arch_test.sh

5c17345

AntonMFernando-NOAA requested review from DavidHuber-NOAA and WalterKolczynski-NOAA July 17, 2024 15:28

github-advanced-security AI found potential problems Jul 17, 2024

View reviewed changes

Comment thread jobs/rocoto/arch_test.sh Fixed

aerorahul requested changes Jul 17, 2024

View reviewed changes

Comment thread workflow/rocoto/gefs_tasks.py Outdated

Comment thread workflow/rocoto/gefs_tasks.py Outdated

Comment thread parm/config/gefs/config.resources Outdated

AntonMFernando-NOAA added 7 commits July 17, 2024 15:24

modified parm/config/gefs/config.resources

c1e55ef

Modified /work2/noaa/global/antonf/global-workflow/workflow/rocoto/ge…

9b2343d

…fs_tasks.py

modified /work2/noaa/global/antonf/global-workflow/workflow/rocoto/ge…

1e0cc66

…fs_tasks.py

modified global-workflow/workflow/rocoto/gefs_tasks.py

a95e2a0

Modified gefs_tasks.py

6b7cf11

modified gefs_tasks.py

5ac0234

modified gefs_tasks.py

ffc6d83

AntonMFernando-NOAA requested a review from aerorahul July 18, 2024 20:21

aerorahul reviewed Jul 18, 2024

View reviewed changes

Comment thread workflow/rocoto/gefs_tasks.py Outdated

aerorahul reviewed Jul 18, 2024

View reviewed changes

Comment thread workflow/rocoto/gefs_tasks.py Outdated

AntonMFernando-NOAA and others added 4 commits July 20, 2024 00:29

Modified gefs_task.py (added envars)

9d15072

removed f in the dependencies

907dd5f

removed f

b71316f

Merge branch 'NOAA-EMC:develop' into feature/get-arch

a42eddd

aerorahul reviewed Jul 22, 2024

View reviewed changes

Comment thread workflow/rocoto/gefs_tasks.py Outdated

AntonMFernando-NOAA and others added 3 commits August 6, 2024 12:03

Merge branch 'NOAA-EMC:develop' into feature/get-arch

d0c216f

modified arch_test.sh

faaac8b

Merge branch 'feature/get-arch' of https://github.com/AntonMFernando-…

b623210

…NOAA/global-workflow into feature/get-arch

Make arch_test.sh executable

6fb6cbf

WalterKolczynski-NOAA added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Aug 6, 2024

WalterKolczynski-NOAA approved these changes Aug 6, 2024

View reviewed changes

DavidHuber-NOAA approved these changes Aug 6, 2024

View reviewed changes

Merge branch 'NOAA-EMC:develop' into feature/get-arch

0a90507

TerrenceMcGuinness-NOAA removed the CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress label Aug 7, 2024

WalterKolczynski-NOAA merged commit 5c2e9b1 into NOAA-EMC:develop Aug 7, 2024

AntonMFernando-NOAA deleted the feature/get-arch branch August 7, 2024 18:35

AntonMFernando-NOAA mentioned this pull request Aug 7, 2024

Add an archive task to GEFS system to archive files locally #2816

Merged

7 tasks

AntonMFernando-NOAA mentioned this pull request Sep 23, 2024

Add an archive task to GEFS system to archive files in HPSS #2895

Merged

7 tasks

bbakernoaa pushed a commit to bbakernoaa/global-workflow that referenced this pull request Mar 19, 2026

Update tests such that LSM and LANDICE are set appropriately (NOAA-EM…

990ca94

…C#2772) * UFSWM - Update default_vars and tests so that LSM 1/2 sets LANDICE true/false appropriately.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/get arch adds an empty archive job to GEFS system#2772

Feature/get arch adds an empty archive job to GEFS system#2772
WalterKolczynski-NOAA merged 44 commits into
NOAA-EMC:developfrom
AntonMFernando-NOAA:feature/get-arch

AntonMFernando-NOAA commented Jul 17, 2024 •

edited

Loading

Uh oh!

Uh oh!

aerorahul left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AntonMFernando-NOAA commented Aug 6, 2024 •

edited

Loading

Uh oh!

WalterKolczynski-NOAA commented Aug 6, 2024

Uh oh!

DavidHuber-NOAA commented Aug 6, 2024

Uh oh!

AntonMFernando-NOAA commented Aug 6, 2024

Uh oh!

emcbot commented Aug 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

AntonMFernando-NOAA commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Uh oh!

Uh oh!

aerorahul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AntonMFernando-NOAA commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WalterKolczynski-NOAA commented Aug 6, 2024

Uh oh!

DavidHuber-NOAA commented Aug 6, 2024

Uh oh!

AntonMFernando-NOAA commented Aug 6, 2024

Uh oh!

emcbot commented Aug 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AntonMFernando-NOAA commented Jul 17, 2024 •

edited

Loading

AntonMFernando-NOAA commented Aug 6, 2024 •

edited

Loading