Skip to content

The soca fix path is needed in config.prepoceanobs#2460

Merged
aerorahul merged 2 commits into
NOAA-EMC:developfrom
guillaumevernieres:feature/soca-fix-to-oceanobsprep
Apr 5, 2024
Merged

The soca fix path is needed in config.prepoceanobs#2460
aerorahul merged 2 commits into
NOAA-EMC:developfrom
guillaumevernieres:feature/soca-fix-to-oceanobsprep

Conversation

@guillaumevernieres
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres commented Apr 5, 2024

Description

Give the prepoceanobs task access to SOCA_INPUT_FIX_DIR, which will be needed for some of the obs processing.

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Ran the ocean obs prep job

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

aerorahul
aerorahul reviewed Apr 5, 2024
View reviewed changes
Comment thread parm/config/gfs/config.prepoceanobs
aerorahul
aerorahul approved these changes Apr 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right.

@aerorahul aerorahul merged commit 59cdc0e into NOAA-EMC:develop Apr 5, 2024
@guillaumevernieres
Copy link
Copy Markdown
Contributor Author

guillaumevernieres commented Apr 5, 2024

Thanks for the quick merge!

danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 8, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
c3d43b9 
* upstream/develop:
  Flip the build for GFS and GEFS with waves (NOAA-EMC#2462)
  Add new data sources used in GFS v16.3.12 (NOAA-EMC#2283)
  The soca fix path is needed in config.prepoceanobs (NOAA-EMC#2460)
  Turn off reducedgrid in the EnKF (NOAA-EMC#2456)
  Rename generate_com to declare_from_tmpl (NOAA-EMC#2453)
@guillaumevernieres guillaumevernieres deleted the feature/soca-fix-to-oceanobsprep branch July 1, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul aerorahul approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guillaumevernieres @aerorahul