Rename generate_com to declare_from_tmpl#2453
Merged
aerorahul merged 1 commit intoApr 4, 2024
Merged
Conversation
The `generate_com` function is renamed to `declare_from_tmpl`. NCO requested the change, and the new name more accurately represents the functionality. Resovles NOAA-EMC#2344
KateFriedman-NOAA
approved these changes
Apr 3, 2024
Contributor
KateFriedman-NOAA
left a comment
KateFriedman-NOAA
left a comment
There was a problem hiding this comment.
Looks good, thanks for renaming this @WalterKolczynski-NOAA !
WalterKolczynski-NOAA
added
the
CI-Orion-Ready
emcbot
added
CI-Orion-Building
|
CI SUCCESS Orion at 04 03 18:51:17 Built and ran in directory |
emcbot
added
the
CI-Orion-Passed
danholdaway
added a commit
to danholdaway/global-workflow
that referenced
this pull request
Apr 8, 2024
* upstream/develop: Flip the build for GFS and GEFS with waves (NOAA-EMC#2462) Add new data sources used in GFS v16.3.12 (NOAA-EMC#2283) The soca fix path is needed in config.prepoceanobs (NOAA-EMC#2460) Turn off reducedgrid in the EnKF (NOAA-EMC#2456) Rename generate_com to declare_from_tmpl (NOAA-EMC#2453)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
generate_comfunction is renamed todeclare_from_tmpl. NCO requested the change, and the new name more accurately represents the functionality.Resolves #2344
Type of change
Change characteristics
How has this been tested?
Checklist