Eliminates all machine detection outside detech_machine.sh#2324
Closed
HenryRWinterbottom wants to merge 10 commits into
Closed
Eliminates all machine detection outside detech_machine.sh#2324HenryRWinterbottom wants to merge 10 commits into
detech_machine.sh#2324HenryRWinterbottom wants to merge 10 commits into
Conversation
…redundant checks for expected file paths.
aerorahul
requested changes
Feb 16, 2024
Contributor
aerorahul
left a comment
There was a problem hiding this comment.
This can be condensed with case. See suggestions.
aerorahul
reviewed
Feb 16, 2024
KateFriedman-NOAA
approved these changes
Feb 20, 2024
Contributor
KateFriedman-NOAA
left a comment
There was a problem hiding this comment.
Looks good, thanks @HenryWinterbottom-NOAA !
7 tasks
Contributor
|
This was merged with #2239. |
bbakernoaa
pushed a commit
to bbakernoaa/global-workflow
that referenced
this pull request
Mar 19, 2026
…s_cubed_sphere to fix a typo when printing out the nest grid corner locations NOAA-EMC#2323+Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UsersGuide NOAA-EMC#2329 + Orion changes for switch to new OS - Rocky-9 NOAA-EMC#2336 (NOAA-EMC#2324) * CICE - Adds restart write capability at the end of a run for CICE * FV3 - * atmos_cubed_sphere - Update submodule FV3/atmos_cubed_sphere to fix a typo when printing out the nest grid corner locations * doc/UsersGuide/requirements.txt: Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2. * Orion Spack stack modulefile update: Rocky-9 * update detect_machine.sh: hercules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #2129. The following is accomplished:
detect_machine.shis removed fromush/load_fv3gfs_modules.shandufs/load_ufsda_modules.sh;File system/partition checks are replaced with
${MACHINE_ID}.Resolves Eliminate all machine detection outside of detect_machine.sh #2129
Type of change
Change characteristics
How has this been tested?
Testing was performed on RDHPCS Hera. A C96 3DVAR experiment was configured and run such that
ush/load_fv3gfs_modules.shandufs/load_ufsda_modules.share excercised. The following global-workflow configurtaion was used:./setup_expt.py gfs cycled --app ATM --resdetatmos 96 --comroot ${WORKSPACE}/COMROOT --expdir ${WORKSPACE}/EXPDIR --idate 2021122018 --edate 2021122100 --pslot x005_gwdev_issue_2129 --icsdir /scratch1/NCEPDEV/global/glopara/data/ICSDIR/C96C48/ --nens 0The following is the Rocoto status for the relevant tasks:
Note that the DA tasks, specifically
gfsanalandgdasanalrun to completion.Checklist