Add aerosol DA capabilities to the C96 atm-snow DA test by CoryMartin-NOAA · Pull Request #2323 · NOAA-EMC/global-workflow

CoryMartin-NOAA · 2024-02-16T16:17:59Z

Description

This PR adds in 3DVar JEDI-based aerosol DA to the C96 atm-snow DA CI test.
Also included is a fix to copy the gocart inst_aod files that are hard coded to every 6 hours of the forecast. Thanks to @aerorahul for the help with that.

Things to note:
The B is 'identity', a future PR will likely add a realistic background error to the test.

This requires 1) new obs added to the dump, and 2) modified ICs for this test period (the gfs_ctrl and gfs_data.tile* files, the sfc* files are untouched). Both can be found on Hera at: /scratch1/NCEPDEV/da/Cory.R.Martin/testdata_aero or on Orion at: /work2/noaa/da/cmartin/work/feb2024/aero/testdata_aero

Resolves #2072
Partially resolves #1821

-->

Type of change

New feature (adds functionality)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

Example:

Cycled test on Orion
-->

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

CoryMartin-NOAA · 2024-03-01T21:06:18Z


  if [[ ! -d "${COM_CHEM_HISTORY}" ]]; then mkdir -p "${COM_CHEM_HISTORY}"; fi

+  GOCART_OUTPUT_FH=$(seq -s ' ' "${FHMIN}" "6" "${FHMAX}")


@aerorahul I thought I tested this but it seems it doesn't work...

oh, it's the ensemble fcst, somehow it's treated differently here?

I think once #2318 is addressed the line here as-is will be fine, but as it stands now, if you run in ATMA mode with an ensemble forecast FHMIN is 3 instead of 0, and then there isn't a gocart file at hour 3.

CoryMartin-NOAA · 2024-02-16T16:20:14Z

This is in draft, because the ICs and obs need to be moved to the appropriate locations first

KateFriedman-NOAA · 2024-02-16T17:01:27Z

@CoryMartin-NOAA I have copied the provided obs into the GDA on Hera:

[role.glopara@hfe02 dump]$ pwd
/scratch1/NCEPDEV/global/glopara/dump
[role.glopara@hfe02 dump]$ ll g*2021122*/*/*viirs*                                                                                                               
-rw-r--r-- 1 role.glopara global 967425 Feb 16 16:13 gdas.20211220/18/gdas.t18z.viirs_n20.2021122018.nc4
-rw-r--r-- 1 role.glopara global 967425 Feb 16 16:13 gdas.20211220/18/gdas.t18z.viirs_npp.2021122018.nc4
-rw-r--r-- 1 role.glopara global 917601 Feb 16 16:13 gdas.20211221/00/gdas.t00z.viirs_n20.2021122100.nc4
-rw-r--r-- 1 role.glopara global 985169 Feb 16 16:13 gdas.20211221/00/gdas.t00z.viirs_npp.2021122100.nc4
-rw-r--r-- 1 role.glopara global 967425 Feb 16 16:13 gfs.20211220/18/gfs.t18z.viirs_n20.2021122018.nc4
-rw-r--r-- 1 role.glopara global 967425 Feb 16 16:13 gfs.20211220/18/gfs.t18z.viirs_npp.2021122018.nc4
-rw-r--r-- 1 role.glopara global 917601 Feb 16 16:13 gfs.20211221/00/gfs.t00z.viirs_n20.2021122100.nc4
-rw-r--r-- 1 role.glopara global 985169 Feb 16 16:13 gfs.20211221/00/gfs.t00z.viirs_npp.2021122100.nc4

Let me know if you need these synced to Orion or WCOSS2 GDAs.

CoryMartin-NOAA · 2024-02-16T17:02:57Z

@KateFriedman-NOAA orion would be great, WCOSS is not necessary at this point (can't even build there!)

KateFriedman-NOAA · 2024-02-16T17:28:35Z

@KateFriedman-NOAA orion would be great, WCOSS is not necessary at this point (can't even build there!)

@WalterKolczynski-NOAA Please sync the 20211220 and 20211221 GDA from Hera to Orion. Thanks!

KateFriedman-NOAA · 2024-02-16T17:30:32Z

modified ICs for this test period (the gfs_ctrl and gfs_data.tile* files, the sfc* files are untouched).

@CoryMartin-NOAA Are these a new set of ICs or they should overwrite existing ones?

CoryMartin-NOAA · 2024-02-16T17:31:53Z

I believe they should overwrite the C96 gdas ICs but we should double check with @aerorahul if they should be overwritten or supplemented (for now)

…in-NOAA/global-workflow into feature/gocart_inst_aod

WalterKolczynski-NOAA · 2024-03-11T18:13:48Z

Dump sync'd to Orion

KateFriedman-NOAA · 2024-03-11T18:19:26Z

@CoryMartin-NOAA Getting back to this, apologies for not completing the ICs part. Question, I don't see an enkf folder in your ICs but our current C96C48 set has enkf ICs too:

[role.glopara@hfe07 ICSDIR]$ ll /scratch1/NCEPDEV/da/Cory.R.Martin/testdata_aero/ICs/
total 4
drwxr-sr-x 4 Cory.R.Martin da 4096 Feb 16 16:12 gdas.20211220
[role.glopara@hfe07 ICSDIR]$ ll C96C48 
total 8
drwxr-sr-x 4 role.glopara global 4096 Jan  5 16:33 enkfgdas.20211220
drwxr-sr-x 4 role.glopara global 4096 Jan  5 16:40 gdas.20211220

Am I overwriting just the gdas.PDY folder with your ICs?

Also, once I pull your ICs in are you testing or shall we test with CI?

CoryMartin-NOAA · 2024-03-11T18:21:22Z

@KateFriedman-NOAA we won't have aerosols in the EnKF, so it will just be the GDAS directory. Once pulling those in, please test with CI, it should work, but I can debug if things fail. Let me merge in develop here first since it's been a month.

KateFriedman-NOAA · 2024-03-11T18:46:55Z

@CoryMartin-NOAA Sounds good. I've pulled your gdas.PDY ICs into the C96C48 set on Hera:

[role.glopara@hfe07 C96C48]$ pwd
/scratch1/NCEPDEV/global/glopara/data/ICSDIR/C96C48
[role.glopara@hfe07 C96C48]$ ll
total 12
drwxr-sr-x 4 role.glopara global 4096 Jan  5 16:33 enkfgdas.20211220
drwxr-sr-x 4 role.glopara da     4096 Feb 16 16:12 gdas.20211220
drwxr-sr-x 4 role.glopara global 4096 Jan  5 16:40 gdas.20211220_SAVE_ORIG

I saved the prior ones just in case.

Confirm this meets your request and we'll sync these ICs to the other platforms and can fire off CI tests.

CoryMartin-NOAA · 2024-03-11T18:48:33Z

@KateFriedman-NOAA yes, please do, thanks!

KateFriedman-NOAA · 2024-03-12T12:52:46Z

I have synced the ICs to both WCOSS2s. Jet is down for maintenance. @WalterKolczynski-NOAA please sync the updated C96C48 ICs to Orion, thanks!

aerorahul · 2024-03-12T21:16:45Z

@CoryMartin-NOAA
I am merging this PR into #2387 and will address the issues from jinja templates in the gdas app.

…s_cubed_sphere to fix a typo when printing out the nest grid corner locations NOAA-EMC#2323+Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UsersGuide NOAA-EMC#2329 + Orion changes for switch to new OS - Rocky-9 NOAA-EMC#2336 (NOAA-EMC#2324) * CICE - Adds restart write capability at the end of a run for CICE * FV3 - * atmos_cubed_sphere - Update submodule FV3/atmos_cubed_sphere to fix a typo when printing out the nest grid corner locations * doc/UsersGuide/requirements.txt: Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2. * Orion Spack stack modulefile update: Rocky-9 * update detect_machine.sh: hercules

CoryMartin-NOAA added 4 commits February 15, 2024 15:22

gocart inst_aod fix

c740e56

Missing GOCART spot

a2a9a2c

Update gdas hash

d371fca

modify snow DA test to include aero DA

24146ff

CoryMartin-NOAA self-assigned this Feb 16, 2024

CoryMartin-NOAA requested review from DavidHuber-NOAA, KateFriedman-NOAA, WalterKolczynski-NOAA and aerorahul February 16, 2024 16:18

github-advanced-security AI found potential problems Feb 16, 2024

View reviewed changes

Merge branch 'develop' into feature/gocart_inst_aod

430cc08

CoryMartin-NOAA marked this pull request as ready for review February 29, 2024 19:18

CoryMartin-NOAA added 3 commits February 29, 2024 14:18

Merge branch 'develop' into feature/gocart_inst_aod

ae81057

random bugfix

f7a1303

Merge branch 'feature/gocart_inst_aod' of https://github.com/CoryMart…

9617d65

…in-NOAA/global-workflow into feature/gocart_inst_aod

Merge branch 'develop' into feature/gocart_inst_aod

d303281

Merge branch 'develop' into feature/gocart_inst_aod

154e792

aerorahul closed this Mar 12, 2024

aerorahul mentioned this pull request Mar 12, 2024

Parse jediyaml only once #2387

Merged

7 tasks

CoryMartin-NOAA deleted the feature/gocart_inst_aod branch June 14, 2024 18:11


		if [[ ! -d "${COM_CHEM_HISTORY}" ]]; then mkdir -p "${COM_CHEM_HISTORY}"; fi

		GOCART_OUTPUT_FH=$(seq -s ' ' "${FHMIN}" "6" "${FHMAX}")

Conversation

CoryMartin-NOAA commented Feb 16, 2024

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Uh oh!

Check warning

CoryMartin-NOAA Mar 1, 2024

Choose a reason for hiding this comment

Uh oh!

CoryMartin-NOAA Mar 1, 2024

Choose a reason for hiding this comment

Uh oh!

CoryMartin-NOAA Mar 1, 2024

Choose a reason for hiding this comment

Uh oh!

CoryMartin-NOAA commented Feb 16, 2024

Uh oh!

KateFriedman-NOAA commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CoryMartin-NOAA commented Feb 16, 2024

Uh oh!

KateFriedman-NOAA commented Feb 16, 2024

Uh oh!

KateFriedman-NOAA commented Feb 16, 2024

Uh oh!

CoryMartin-NOAA commented Feb 16, 2024

Uh oh!

WalterKolczynski-NOAA commented Mar 11, 2024

Uh oh!

KateFriedman-NOAA commented Mar 11, 2024

Uh oh!

CoryMartin-NOAA commented Mar 11, 2024

Uh oh!

KateFriedman-NOAA commented Mar 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CoryMartin-NOAA commented Mar 11, 2024

Uh oh!

KateFriedman-NOAA commented Mar 12, 2024

Uh oh!

aerorahul commented Mar 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KateFriedman-NOAA commented Feb 16, 2024 •

edited

Loading

KateFriedman-NOAA commented Mar 11, 2024 •

edited

Loading