Feature/refactor gfs init#1449
Closed
HenryRWinterbottom wants to merge 34 commits into
Closed
Conversation
There was a problem hiding this comment.
shellcheck found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides an application to initialize the FV3 GFS run-time path, with the exception of the tables and
input.nml. The creation of the tables is a simple addition. The implementation ofinput.nmlrequires additional discussions with the core development team.Type of Change
How Has This Been Tested?
Currently the only testing methodology has been via evaluation of the directory tree. Full unit-tests will be need to be defined and will compose a future PR.
Checklist
Notes
The following variables should be added to run-time configuration (e.g., environment) to provide additional flexibility for
model_configure:calendar; current default isjulian;output_1st_tstep_rst; current default is.false.;quilting; this determination is made somewhere at the configuration and task (e.g.,jobsandscripts) levels; for this draft PR aquiltingvalue, as a function of cubed-sphere resolution has been added to the grid configuration classpygfs.utils.grids.FV3GFS;filename_base_atmandfilename_base_sfchave been defined withinmodel_configure; the default values remain asatmandsfc, respectively.The
model_configurefile has been entirely templated and should not require user modifications. All modifications are made at the run-time and configuration level. We strongly suggest that this is at least a component of the creation ofinput.nml.