Skip to content

Add PYTHONPATH to soca ocean prep jjob#1292

Merged
WalterKolczynski-NOAA merged 2 commits into
NOAA-EMC:developfrom
AndrewEichmann-NOAA:feature/use-pythonpath-in-soca
Jan 31, 2023
Merged

Add PYTHONPATH to soca ocean prep jjob#1292
WalterKolczynski-NOAA merged 2 commits into
NOAA-EMC:developfrom
AndrewEichmann-NOAA:feature/use-pythonpath-in-soca

Conversation

@AndrewEichmann-NOAA
Copy link
Copy Markdown
Contributor

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Jan 30, 2023

Description

Adds the UFSDA location to PYTHONPATH in soca prep jjob so the path building is not done in script.

Addresses GDASApp issues NOAA-EMC/GDASApp#242 and NOAA-EMC/GDASApp#234

The issues require changes also to GDASApp, but this PR will not break GDASApp as is

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested with soca/global-workflow GDASApp ctests on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published - TBD

@AndrewEichmann-NOAA
Copy link
Copy Markdown
Contributor Author

@guillaumevernieres FYI

Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. We'll have to modify the script in the gdasapp next, but all good for this repo. Thanks @AndrewEichmann-NOAA

Comment thread jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP Outdated
@AndrewEichmann-NOAA AndrewEichmann-NOAA requested review from guillaumevernieres and removed request for aerorahul January 31, 2023 17:15
@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title add PYTHONPATH to soca prep jjob Add PYTHONPATH to soca prep jjob Jan 31, 2023
@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title Add PYTHONPATH to soca prep jjob Add PYTHONPATH to soca ocean prep jjob Jan 31, 2023
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 6b5d92d into NOAA-EMC:develop Jan 31, 2023
@AndrewEichmann-NOAA
Copy link
Copy Markdown
Contributor Author

Thank you!

@AndrewEichmann-NOAA AndrewEichmann-NOAA deleted the feature/use-pythonpath-in-soca branch January 31, 2023 17:59
bbakernoaa pushed a commit to bbakernoaa/global-workflow that referenced this pull request Mar 19, 2026
…on info to wiki; Update P8 sfc ICs for FV3; Update WW3_inputdata directory; Bug fix for NOAA-EMC#1309: false reports of test failures (NOAA-EMC#1292)

*add documentation for generating wave model meshes

* set wave domain explicitly

* all baselines pass if retain mx025 for bmark_p8

* switch glo_30m to gwes_30m

* switch bmark_p8 test to use gwes_30m domain

* update WW3 input directory

* update WW3 input directory for oRT script

* switch mesh_wave for the 35d test

* switch sfc input for FV3BMIC to p8c directory

* Bug fix for NOAA-EMC#1309: false reports of test failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants