removed pythonpath construction from script#307
Merged
Conversation
guillaumevernieres
approved these changes
Jan 30, 2023
Contributor
guillaumevernieres
left a comment
There was a problem hiding this comment.
Yup, I think that should do it. Thanks @AndrewEichmann-NOAA .
|
Automated GDASApp Testing Results: |
|
Automated GDASApp Testing Results: |
Collaborator
Author
|
@guillaumevernieres NOAA-EMC/global-workflow#1292 has been merged, so this should be safe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effectively outsourced construction of what gets imported as the env variable PYTHONPATH to the environment. No changes were required in
CMakeLists.txtbecause the necessary path construction was already there. So it's just removal of the additions tosys.pathinscripts/exgdas_global_marine_analysis_prep.py.Addresses issues #242 and #234 . Should break ctest
test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREPand dependencies until NOAA-EMC/global-workflow#1292 is merged.