Skip to content

Ca develop#87

Merged
DusanJovic-NOAA merged 42 commits into
NOAA-EMC:developfrom
lisa-bengtsson:CA_develop
May 4, 2020
Merged

Ca develop#87
DusanJovic-NOAA merged 42 commits into
NOAA-EMC:developfrom
lisa-bengtsson:CA_develop

Conversation

@lisa-bengtsson
Copy link
Copy Markdown
Contributor

@lisa-bengtsson lisa-bengtsson commented Mar 24, 2020

Updates to cellular automata for deep convection. Some cleaning. Changes goes with updates in stochastic_physics and ccpp/physics repositories.

NCAR ccpp/physics #418
noaa-psd/stochastic_physics #15
#87
ufs-weather-model #96

@climbfuji
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

@pjpegion pjpegion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@climbfuji
Copy link
Copy Markdown
Collaborator

These changes look ok to me. In a follow-up PR, you could move vfact_ca from Coupling to Model, because this data is static and does not depend on the grid columns as far as I can see. This would also allow you to implement my suggestion for moving the vfact_ca initialization code into GFS_stochastics_init. And it saves memory, because as part of Model vfact_ca is only allocated one time per MPI task, while it is allocated nblock number of times as part of Coupling.

@DusanJovic-NOAA DusanJovic-NOAA merged commit e8fd6ee into NOAA-EMC:develop May 4, 2020
ShanSunNOAA pushed a commit to ShanSunNOAA/ufsatm that referenced this pull request May 3, 2021
…ss-modules

Move all GSD chemistry process modules from ccpp-physics to GOCART
LarissaReames pushed a commit to LarissaReames/fv3atm that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants