Update with more recent changes from NCAR fork

[mkavulich]

Description

This update brings in improvements from the NCAR fork:

• Reorganizing code
  • Move code into subroutines
    • Set time stamps
    • allocate variables
    • set initial values
    • set initial times
  • Remove old references to Geogrid
  • Compile fixes for uninitialized variables
• Adding OpenMP parallelization
  • Tiles functionality with one core NCAR/fire_behavior#11
  • Adding OpenMP parallelization NCAR/fire_behavior#12
  • Automatic compilation supports OpenMP NCAR/fire_behavior#13
  • Improved calculation of tile dimensions NCAR/fire_behavior#16
• Adding a new namelist option wind_vinterp_opt; when set to 1, this uses 10 meter wind from the model as forcing for the fire rather than the full 3D wind field
  • Adding 10 m winds to the fire nuopc NCAR/fire_behavior#14

This branch also includes some changes that do not impact the fire_behavior module coupled to ufsatm:

• Feature wrf coupling NCAR/fire_behavior#8 (only affects WRF)
• Idealized simulations NCAR/fire_behavior#9, Ideal block in the namelist is not mandatory NCAR/fire_behavior#10 (offline coupling only)
• Several other commits related to WRF coupling

Testing

UFS WM Regression tests pending. New code runs successfully in UFS SRW code framework, including new namelist option and OpenMP parallelism.

[gspetro-NOAA]

Could we get reviews on this PR so that we can process ufs-community/ufs-weather-model#3126?

[gspetro-NOAA]

@pedro-jm @masih-e Could one of you (or someone else familiar w/the fire behavior codebase) review this PR soon? We are hoping to process the parent PR (ufs-community/ufs-weather-model#3126) tomorrow, but if that won't be possible, we'd like to know.

[masih-e]

The changes look good to me.

[pedro-jm]

@gspetro-NOAA Same here, this looks good to me. You can go ahead and merge from our side. We do no have the option of reviewing the PR in the standard github way and approve. So we approve via these comments.

[gspetro-NOAA]

@gspetro-NOAA Same here, this looks good to me. You can go ahead and merge from our side. We do no have the option of reviewing the PR in the standard github way and approve. So we approve via these comments.

Thanks! I will let the WM CMs know. The merge probably wouldn't be until Friday, after full regression tests, but I'm not sure we have permissions to merge. Who should we reach out to when we are ready to merge?

[pedro-jm]

@gspetro-NOAA I believe @danrosen25 made me maintainer and I can merge PRs now. So I guess I would be the one, keep @danrosen25 and posted too. Thanks.

[danrosen25]

@gspetro-NOAA
Is there a maintainer (or admin) at NOAA that I can add to this repository?

[gspetro-NOAA]

@gspetro-NOAA Is there a maintainer (or admin) at NOAA that I can add to this repository?

@dpsarmie Could you look into this?

[dpsarmie]

@danrosen25 Yes, I can act as a point of contact at EMC for this repository, but all approvals and reviews should still be taken care of by fire behavior folks who are more knowledgeable about the code.
If you're asking for code managers from NOAA for this repo, let me know and I'll ask around to see if that's a possibility.

[pedro-jm]

@dpsarmie yes, we will review/approve the fire behavior code. Makes sense.

[mkavulich]

Note I have removed the commit that removed documentation updates, so now there are additional changes compared to the version that has been approved. These changes are documentation-only, so should not affect results. See the discussion on the Weather Model PR starting here for more information on why this was done.

[gspetro-NOAA]

@pedro-jm Testing completed successfully on ufs-community/ufs-weather-model#3126. Please merge this PR as soon as you have a chance. :)