Automatic compilation supports OpenMP#13
Merged
Conversation
mkavulich
reviewed
Jul 24, 2025
| add_compile_definitions(firelib PUBLIC DM_PARALLEL=1) | ||
| endif() | ||
|
|
||
| if(ENABLE_OPENMP) |
Collaborator
There was a problem hiding this comment.
In ufs-weather-model, this activation variable is OPENMP rather than ENABLE_OPENMP (https://github.com/ufs-community/ufs-weather-model/blob/develop/CMakeLists.txt#L74). It may make sense to stay consistent with that convention.
Collaborator
Author
There was a problem hiding this comment.
@mkavulich yes, thanks, I think you are right. We will have to change it.
Collaborator
There was a problem hiding this comment.
WRF uses USE_OPENMP, however to add to @mkavulich's comment if the CFBM will primarily be meant to be used within ufs-weather-model then this should be changed to be more inline with that.
On the WRF side, we can internally translate USE_OPENMP -> OPENMP just before including the fire project directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the cmake compilation to include support for OpenMP builds