Update ww3_gint to interpolate restart files #962
Merged
MatthewMasarik-NOAA merged 17 commits intoApr 4, 2023
Merged
Conversation
Contributor
|
This is great to see @JessicaMeixner-NOAA!! I'll start the regression tests. |
Contributor
|
Status update: I just spoke with @JessicaMeixner-NOAA, and we are both following up one difference that came up in the regtests results. |
Contributor
|
Status: Hera is unavailable today for maintenance. This PR will finish being process tomorrow once hera is back online for developers. |
MatthewMasarik-NOAA
approved these changes
Apr 4, 2023
Contributor
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt
Code Revew PASS
Testing PASS
This is a very exciting capability to now for restart files! Thank you @JessicaMeixner-NOAA for your determined work to bring this to fruition!!
Collaborator
|
This is a really useful feature. Thanks @JessicaMeixner-NOAA . |
This was referenced Apr 13, 2023
37 tasks
JessicaMeixner-NOAA
added a commit
that referenced
this pull request
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR updates ww3_gint to optionally interpolate restart files.
Description
This updates ww3_gint to interpolate restart files as an option. This is selected via the input file by ww3_gint.inp in the first line to now have the last option:
Time, time increment and number of outputs, and optional T/F -- option (default is T) to indicate out_grd (T) or restart (F)A new set of regression tests for this is added:
which shows the use case of initializing a regional system from a global system.
Issue(s) addressed
Commit Message
Update ww3_gint to interpolate restart files
Check list
Testing
Only the new test
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt