Sync develop to dev/ufs-weather-model #957
Merged
JessicaMeixner-NOAA merged 5 commits intoMar 28, 2023
Merged
Conversation
…main decomposition. (NOAA-EMC#943)
…n. By-pass mpi send/recv set-up in w3initmd when using domain decomposition. (NOAA-EMC#949)
…d approach. (NOAA-EMC#888) * Consolidation and performance improvements of wave setup computation on structured and unstructured grids. * Performance and memory improvement of the unstructured framework. * Introduction of a new limiter (mixture of Hersbach & Janssen + Komen etal.) * Alternative computations of the group velocity for unstructured grids * Introduce under-relaxation for triads and wave breaking * Improve shallow-water source term integration for explicit source terms within the unstructured down-scaling approach. * Bug fixes for wetting & drying for both implicit and explicit schemes. * Bug fix for the wave triad interaction. * Introduce coastline reflection for the implicit scheme, and homogenization within the new wetting & drying scheme. * Introduction of Block Explicit Solver as an option for unstructured meshes. * Consolidation of the implicit solver in terms of memory usage, coherence. * debug output and further work on the Jacobi solver towards CPU coherency of the Jacobi solver. * Fix bugs and clean & test 2nd order time-space LAX-FCT-CRD scheme. Co-authored-by: aliabdolali <ali.abdolali@noaa.gov> Co-authored-by: Ty Hesser <thesser1@gmail.com>
Conflicts: model/src/w3wavemd.F90
37 tasks
4 tasks
DeniseWorthen
approved these changes
Mar 22, 2023
Contributor
DeniseWorthen
left a comment
DeniseWorthen
left a comment
There was a problem hiding this comment.
matches my add_unstr_wise branch, minus the changes for unstructured in the mesh cap itself.
MatthewMasarik-NOAA
approved these changes
Mar 24, 2023
Contributor
MatthewMasarik-NOAA
left a comment
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
The code review checks out.
@JessicaMeixner-NOAA has successfully tested both intel / gnu on hera and posted the logs here: ufs-community/ufs-weather-model#1673 (comment).
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This syncs the develop branch to dev/ufs-weather-model branch
Description
Three main PRs of note include:
Issue(s) addressed
ufs-community/ufs-weather-model#1668
Commit Message
Sync develop to dev/ufs-wetaher-model
Check list
Testing
n/a