Skip to content

Typographic corrections.#951

Merged
MatthewMasarik-NOAA merged 1 commit into
NOAA-EMC:developfrom
MathieuDutSik:typos
Mar 21, 2023
Merged

Typographic corrections.#951
MatthewMasarik-NOAA merged 1 commit into
NOAA-EMC:developfrom
MathieuDutSik:typos

Conversation

@MathieuDutSik
Copy link
Copy Markdown
Contributor

Pull Request Summary

Correction of some typographic errors.

Description

Error messages can be erroneous, here I correct some points.

Issue(s) addressed

No issues.

Commit Message

Correction of some typographic errors.

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@MatthewMasarik-NOAA
Copy link
Copy Markdown
Contributor

Thank you @MathieuDutSik. @JessicaMeixner-NOAA has already started the regtests.

Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While there was zero expectation that code would change, regtests were run out of an abundance of caution. Results were as expected.

Test were run w/intel on Hera:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Not b4b tests are as expected:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (11 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (13 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
ww3_ta1/./work_UPD0F_U                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.17/./work_ma                     (1 files differ)
ww3_tp2.17/./work_a                     (1 files differ)
ww3_tp2.17/./work_mc1                     (1 files differ)
ww3_tp2.17/./work_mb                     (1 files differ)
ww3_tp2.17/./work_mc                     (1 files differ)
ww3_tp2.17/./work_ma1                     (1 files differ)
ww3_tp2.17/./work_c                     (1 files differ)
ww3_tp2.17/./work_b                     (1 files differ)
ww3_tp2.6/./work_ST0                     (1 files differ)
ww3_tp2.6/./work_ST4                     (1 files differ)
ww3_tp2.6/./work_pdlib                     (1 files differ)
ww3_ts4/./work_ug_MPI                     (1 files differ)
ww3_ufs1.3/./work_a                     (3 files differ) 

@MatthewMasarik-NOAA
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA has run the regtests as a precaution, and everything looks good.

Thank you @MathieuDutSik for contributing this correction.

Approved.

@MatthewMasarik-NOAA MatthewMasarik-NOAA merged commit f1f6c21 into NOAA-EMC:develop Mar 21, 2023
@MathieuDutSik MathieuDutSik deleted the typos branch April 4, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants