Skip to content

removing comp.* link.* files as we now use the cmplr.env#284

Merged
aliabdolali merged 7 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:feature/removeextrabinfiles
Jan 17, 2021
Merged

removing comp.* link.* files as we now use the cmplr.env#284
aliabdolali merged 7 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:feature/removeextrabinfiles

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Jan 5, 2021

This PR removes all of the model/bin/comp.<> & link.<> files as we have transitioned to using the cmplr.env files.

I have not run regression tests yet, as I wanted to make sure there were no objections to the removal of these files. If someone is still using one of the independent comp/link files, we could add them to the cmplr.env.

Update:
PR #283 which removes unused files in the bin directory and PR #279 which got rid of .swp files not intended to be committed to repo have been combined with this PR.

@mickaelaccensi
Copy link
Copy Markdown
Collaborator

I agree to remove those comp & link files.
Also it would be good to remove the if tests on comp and link in section # 3.c Setup comp & link files in w3_setup

@ukmo-ccbunney
Copy link
Copy Markdown
Collaborator

ukmo-ccbunney commented Jan 6, 2021

Sounds like a good idea to me - it would significantly tidy up the bin directory.
On the subject of removing old files, is anyone still using the regtest/matrix.base.v1 file? Can this also be removed (maybe in a different PR?)

@mickaelaccensi
Copy link
Copy Markdown
Collaborator

Sounds like a good idea to me - it would significantly tidy up the bin directory.
On the subject of removing old files, is anyone still using the regtest/matrix.base.v1 file? Can this also be removed (maybe in a different PR?)

I don't use it. so ok for me to also remove it

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

@aliabdolali we could also remove https://github.com/NOAA-EMC/WW3/blob/develop/regtests/bin/matrix_zeus_HLT since we use the ncep one now if you agree.

@mickaelaccensi @ukmo-ccbunney I will remove the extra regtest/matrix.base.v1 file, because I agree it's not being used. In terms of the extra if statements in the w3_setup, I can clean that up too if we want. Do we think everyone has fully transitioned at this point so that's okay to do?

@aliabdolali
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA, @ukmo-ccbunney I agree, we can remove regtest/matrix.base.v1 and regtests/bin/matrix_zeus_HLT. The Matlab scripts haven't been used for a long time, so we can also remove them.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

@aliabdolali the other 2 clean-up related PRs have been added to this branch and it has been updated w/the most recent develop branch. This PR is ready for review and regression testing.

@aliabdolali
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA Awesome, I'll review it and will check regtests today.

Copy link
Copy Markdown
Collaborator

@mickaelaccensi mickaelaccensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.
the next step would be clean up w3_setup and probably move the variables comp_seq and comp_mpi from cmplr.env to wwatch3.env

@aliabdolali
Copy link
Copy Markdown
Contributor

Full regtest results attached:
matrixDiffHERA.zip
All tests compared OK, apart from the usual suspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants