Skip to content

removing file that should not be in repository#279

Closed
JessicaMeixner-NOAA wants to merge 2 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:cleanup/extrafiles
Closed

removing file that should not be in repository#279
JessicaMeixner-NOAA wants to merge 2 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:cleanup/extrafiles

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

No description provided.

@mickaelaccensi
Copy link
Copy Markdown
Collaborator

we should even add a rule in gitconfig to not take into account .swp files

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

@mickaelaccensi we have in .gitignore:

*.swp
*/*.swp
*/*/*.swp
*/*/*/*.swp

already. I would have thought that would have prevented this, but apparently not?

@mickaelaccensi
Copy link
Copy Markdown
Collaborator

mickaelaccensi commented Dec 14, 2020

it's because it's a hidden file. So we need to add :

.*.swp
*/.*.swp
*/*/.*.swp
*/*/*/.*.swp

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

@mickaelaccensi added!

@ukmo-ccbunney
Copy link
Copy Markdown
Collaborator

Do we need all the directory permutations?
I think that the rule *.swp should match any file in the repo, even if it is in a directory.

On my system *.swp ignores all .swp files, regardless of directory depth or if the filename is hidden (starts with a dot).

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

I didn't think you had to have the directory permutations but I'm not sure? Maybe we just already had that file in the repo before the *.swp was added?

@mickaelaccensi
Copy link
Copy Markdown
Collaborator

it's not the case on my system. The dot must be added to filter hidden files.

@ukmo-ccbunney
Copy link
Copy Markdown
Collaborator

it's not the case on my system. The dot must be added to filter hidden files.

Interesting that it is different on your system - maybe a different version of Git (I'm on 2.24.3).
So, perhaps we just need:

*.swp
.*.swp

??

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

Combined into PR #284

@aliabdolali
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA It is merged with #284, can we delete it?

@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the cleanup/extrafiles branch November 13, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants