Skip to content

develop: Fix hang bug by updating MPI bcast to be from 0 not IAPROC-1 #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbanihash merged 2 commits into from
May 19, 2025
Merged

develop: Fix hang bug by updating MPI bcast to be from 0 not IAPROC-1 #1430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
793b916
fix hang in wave model initialization
JessicaMeixner-NOAA May 8, 2025
8f89f73
remove tabs
JessicaMeixner-NOAA May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions model/src/w3iopomd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,16 +607,16 @@ SUBROUTINE W3IOPP ( NPT, XPT, YPT, PNAMES, IMOD, MPI_COMM_IOPP )
! Broadcast weight info to all MPI tasks:

!First broadcast NOPTS, used in the next calls:
CALL MPI_BCAST(NOPTS,1,MPI_INTEGER,IAPROC-1,MPI_COMM_IOPP,IERR_MPI)
CALL MPI_BCAST(NOPTS,1,MPI_INTEGER,0,MPI_COMM_IOPP,IERR_MPI)
CALL MPI_Barrier(MPI_COMM_IOPP,IERR_MPI)

CALL MPI_BCAST(PTLOC,2*NPT,MPI_REAL,IAPROC-1,MPI_COMM_IOPP,IERR_MPI)
CALL MPI_BCAST(PTIFAC,4*NPT,MPI_REAL,IAPROC-1,MPI_COMM_IOPP,IERR_MPI)
CALL MPI_BCAST(IPTINT(:,:,1:NOPTS),2*4*NOPTS,MPI_INTEGER,IAPROC-1,MPI_COMM_IOPP,IERR_MPI)
CALL MPI_BCAST(PTLOC,2*NPT,MPI_REAL,0,MPI_COMM_IOPP,IERR_MPI)
CALL MPI_BCAST(PTIFAC,4*NPT,MPI_REAL,0,MPI_COMM_IOPP,IERR_MPI)
CALL MPI_BCAST(IPTINT(:,:,1:NOPTS),2*4*NOPTS,MPI_INTEGER,0,MPI_COMM_IOPP,IERR_MPI)

!Send point names individually
DO IPT=1, NOPTS
CALL MPI_BCAST(PTNME(IPT),40,MPI_CHARACTER,IAPROC-1,MPI_COMM_IOPP,IERR_MPI)
CALL MPI_BCAST(PTNME(IPT),40,MPI_CHARACTER,0,MPI_COMM_IOPP,IERR_MPI)
ENDDO

CALL MPI_Barrier(MPI_COMM_IOPP,IERR_MPI)
Expand Down Expand Up @@ -2295,8 +2295,8 @@ SUBROUTINE W3IOPO ( INXOUT, NDSOP, IOTST, IMOD &
!
IF (LEN_TRIM(FNMPNT) .EQ. 0) THEN
FNMPRE_LOCAL = FNMPRE
ELSE
FNMPRE_LOCAL = FNMPNT
ELSE
FNMPRE_LOCAL = FNMPNT
END IF
!

Expand Down
Loading