Fix code stability issue #1173 + Fix build 'remarks' PR #1201#1210
Conversation
|
Thanks for this fix PR, @sbanihash. @JessicaMeixner-NOAA or I will be back in touch this afternoon. |
|
@BinLiu-NOAA and @BijuThomas-NOAA can one of you approve that this has been tested in HAFS and is good to be merged? @sbanihash - @MatthewMasarik-NOAA will be making a PR to develop with the fixes that are not already there. |
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
Code review
Pass - the changes cleanly address the issues.
Testing
Pass - the updates from #1201 were tested in our NCEP regtest matrix. @sbanihash and @BijuThomas-NOAA has confirmed the testing for the fix addressing #1173.
Approved.
|
@BijuThomas-NOAA, thank you for bringing this to our attention. Thanks @sbanihash, @BijuThomas-NOAA for providing a nice fix. |
|
Congratulations 🎉 @sbanihash on your first commit to noaa-emc/ww3! |
Pull Request Summary
This PR fixes issue #1173 reported by NCO during HAFS.v1 implementation regarding ww3_outp debug build failure as well as the addition of PR #1201 to address the fix for build remarks
Description
With these changes the debug build will not encounter a failure while running ww3_outp in addition to the elimination of some build remarks for WW3.
Please also include the following information:
Issue(s) addressed
fixes noaa-emc/ww3/issues/< code stability test failed in ww3_outp #1173>
Commit Message
Please provide a short summary of this PR, which will be used during Squash and Merge and will be shown as a git log message. Be sure to add any co-authors here.
Check list
Testing
Four tests were conducted, with and without the fixes, and with Release and Debug build flags. The runs with and without the fixes are reproducible with the Release flag, which is expected. The run with the fix and debug flag fixes the issue with code instability while running ww3_outp. Runs without the fix and with the Debug flag reproduce the error that NCO had reported.
ww3_ufs1.1 was tested. ww3_outp was executed to reproduce the error and check if the bug fix has been effective.
parts of Matrix 12 , on Hera with intel compiler