Update dev/ufs-weather-model branch with develop - 2023-jun-27#1029
Merged
JessicaMeixner-NOAA merged 15 commits intoJul 25, 2023
Merged
Conversation
…ling frequency to check if 'receive' coupling exchanges need to take place fail, resulting in an infinite loop causing the integration between time zero and the first time step to repeat indefinitely. This check needs to be rewritten, which fixes also issue NOAA-EMC#816 in a simpler way. (NOAA-EMC#999)
* origin/develop: handle NaN air-sea temperatures from nearest land points (NOAA-EMC#869) Increase valid_max for f in ounp (NOAA-EMC#1014) Bugfix deallocation of invalid memory in ww3_prnc (NOAA-EMC#1016) Update to orion intel module path and two typo corrections. (NOAA-EMC#1011) Bugfix to out of bounds array write in w3profsmd_pdlib.f90 (NOAA-EMC#1013) Simple logic fix for time interpolation of boundary nodes at the end of W3XYPFSNIMP. (NOAA-EMC#1005) in w3iors use NSEA instead of NSEAL in serial write/read of VA (NOAA-EMC#954) Update documentation for UNST namelist (NOAA-EMC#986) In certain coupled configurations, the piece of code testing the coupling frequency to check if 'receive' coupling exchanges need to take place fail, resulting in an infinite loop causing the integration between time zero and the first time step to repeat indefinitely. This check needs to be rewritten, which fixes also issue NOAA-EMC#816 in a simpler way. (NOAA-EMC#999)
Contributor
Author
|
fyi @JessicaMeixner-NOAA we just need to approve to get into the UFS queue. |
JessicaMeixner-NOAA
approved these changes
Jun 30, 2023
Contributor
Author
|
Thanks @JessicaMeixner-NOAA 👍 |
37 tasks
Contributor
|
@JessicaMeixner-NOAA Can you please give a look over the commits after your approval and re-approve if all looks OK? |
JessicaMeixner-NOAA
approved these changes
Jul 19, 2023
Collaborator
|
@BrianCurtis-NOAA Thanks for your request of re-approval. Everything looks good here! |
|
Hello, testing is complete on UFS-WM PR #1811. @JessicaMeixner-NOAA can you please go ahead to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Syncs updates in
developbranch todev/ufs-weather-modelbranch.Description
Sync develop to dev/ufs-weather-model. No change of answers.
Please also include the following information:
Issue(s) addressed
Commit Message
Sync develop to dev/ufs-weather-model
Check list
Testing
Tested within UFS by running the full RT's. WW3 regression tests are not run for
dev/ufs-weather-model. Test logs are attached to the ufs-weather-model PR, ufs-community/ufs-weather-model/pull/1811.