apply patch for reported issue #967#1005
Merged
Merged
Conversation
Contributor
|
@dpzimmer, thank you for submitting this bug fix! There are two PR's ahead of this one. Mid- next week is a good estimate for processing this PR. |
Contributor
|
@dpzimmer, could you please sync your branch to bring it up-to-date with current develop? I've tested your branch with the latest updates so it is all set from that perspective, and I'll merge it once you've made the update. |
MatthewMasarik-NOAA
approved these changes
May 4, 2023
Contributor
MatthewMasarik-NOAA
left a comment
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
Code review Pass
Testing Pass
The only non-identicals are the known non-b4b's.
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (16 files differ)
mww3_test_03/./work_PR1_MPI_d2 (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (14 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (16 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_ufs1.3/./work_a (3 files differ)
**********************************************************************
************************ identical cases *****************************
**********************************************************************
Contributor
|
Thanks for updating, @dpzimmer. |
Contributor
|
Thank you @dpzimmer (and @aronroland) for this logic fix for the unstructured grid implicit-n solver. |
MatthewMasarik-NOAA
added a commit
to MatthewMasarik-NOAA/WW3
that referenced
this pull request
Jun 27, 2023
* origin/develop: handle NaN air-sea temperatures from nearest land points (NOAA-EMC#869) Increase valid_max for f in ounp (NOAA-EMC#1014) Bugfix deallocation of invalid memory in ww3_prnc (NOAA-EMC#1016) Update to orion intel module path and two typo corrections. (NOAA-EMC#1011) Bugfix to out of bounds array write in w3profsmd_pdlib.f90 (NOAA-EMC#1013) Simple logic fix for time interpolation of boundary nodes at the end of W3XYPFSNIMP. (NOAA-EMC#1005) in w3iors use NSEA instead of NSEAL in serial write/read of VA (NOAA-EMC#954) Update documentation for UNST namelist (NOAA-EMC#986) In certain coupled configurations, the piece of code testing the coupling frequency to check if 'receive' coupling exchanges need to take place fail, resulting in an infinite loop causing the integration between time zero and the first time step to repeat indefinitely. This check needs to be rewritten, which fixes also issue NOAA-EMC#816 in a simpler way. (NOAA-EMC#999)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Pull request generated by invitation of https://github.com/aronroland for revision to address issue reported at #967
Description
Fix inverted logic, multiplying by (1-IOBPD(ITH,IP)) rather than IOBPD(ITH,IP) in subroutine W3XYPFSNIMP of the file w3profsmd.F90.
Issue(s) addressed
When running an unstructured mesh using the implicit-n solver and providing with boundary input, the routine W3XYPFSNIMP clears the boundary input.
Commit Message
Simple logic fix for time interpolation of boundary nodes at the end of W3XYPFSNIMP.
Check list
Testing