Skip to content

[release/rrfs_v1] Removes lines that generate warnings during compilation#967

Merged
WenMeng-NOAA merged 1 commit into
NOAA-EMC:release/rrfs_v1from
MatthewPyle-NOAA:feature/cleancompile
Jun 10, 2024
Merged

[release/rrfs_v1] Removes lines that generate warnings during compilation#967
WenMeng-NOAA merged 1 commit into
NOAA-EMC:release/rrfs_v1from
MatthewPyle-NOAA:feature/cleancompile

Conversation

@MatthewPyle-NOAA
Copy link
Copy Markdown
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA commented Jun 10, 2024

Updates io_int_stubs.f to allow for a warning-free compilation. Haven't made runs with this change, but was hoping that regression tests could validate that it doesn't create a problem.

@MatthewPyle-NOAA MatthewPyle-NOAA mentioned this pull request Jun 10, 2024
Closed
@WenMeng-NOAA WenMeng-NOAA linked an issue Jun 10, 2024 that may be closed by this pull request
Clean up compile warnings within the UPP code #964
Closed
@WenMeng-NOAA WenMeng-NOAA added RRFS Ready for Review This PR is ready for code review. labels Jun 10, 2024
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

WenMeng-NOAA commented Jun 10, 2024

@MatthewPyle-NOAA I conducted a couple UPP standalone tests with your branch. The fix works well.

@MatthewPyle-NOAA
Copy link
Copy Markdown
Contributor Author

MatthewPyle-NOAA commented Jun 10, 2024

Is the Intel Linux Build setup failure a concern, @WenMeng-NOAA ?

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

WenMeng-NOAA commented Jun 10, 2024

Is the Intel Linux Build setup failure a concern, @WenMeng-NOAA ?

@MatthewPyle-NOAA From my WCOSS2 testing, it works well. Can you specify what kind of failure?

@MatthewPyle-NOAA
Copy link
Copy Markdown
Contributor Author

MatthewPyle-NOAA commented Jun 10, 2024

It looks like it might have been a full disk causing the problem. https://github.com/NOAA-EMC/UPP/actions/runs/9448579856

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

WenMeng-NOAA commented Jun 10, 2024

It looks like it might have been a full disk causing the problem. https://github.com/NOAA-EMC/UPP/actions/runs/9448579856

@MatthewPyle-NOAA That's the failure of CI on github. There might be an update of CI configuration at github. As long as our testing at local platforms like WCOSS2, R&D platforms Hera and Orion, works well, we should be fine. We will solve the UPP CI issue later.

@WenMeng-NOAA WenMeng-NOAA merged commit fe5ceb2 into NOAA-EMC:release/rrfs_v1 Jun 10, 2024
WenMeng-NOAA added a commit to WenMeng-NOAA/UPP that referenced this pull request Jun 17, 2024
@WenMeng-NOAA
Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968.
bd4f4f4
This was referenced Jun 17, 2024
Merged
Closed
WenMeng-NOAA added a commit that referenced this pull request Jun 18, 2024
@WenMeng-NOAA @FernandoAndrade-NOAA
Sync the RRFS hotfix #967 and #968. (#979)
d5a7944 
* Sync the RRFS hotfix #967 and #968.

* hera RT log

* hercules RT log

---------

Co-authored-by: FernandoAndrade-NOAA <fernando.andrade-maldonado@noaa.gov>
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Jun 18, 2024
Closed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
9669aba 
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

Assignees

No one assigned

Labels

Ready for Review This PR is ready for code review. RRFS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up compile warnings within the UPP code

2 participants

@MatthewPyle-NOAA @WenMeng-NOAA