Skip to content

bug fixes needed for running with libIFI#646

Merged
WenMeng-NOAA merged 11 commits into
NOAA-EMC:developfrom
SamuelTrahanNOAA:ifi-inline-post
Mar 2, 2023
Merged

bug fixes needed for running with libIFI#646
WenMeng-NOAA merged 11 commits into
NOAA-EMC:developfrom
SamuelTrahanNOAA:ifi-inline-post

Conversation

@SamuelTrahanNOAA
Copy link
Copy Markdown
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Feb 28, 2023

Fixes #647, fixes #648, and fixes #641

  1. Standalone UPP build script can't build libIFI internally due to an error in compile_upp.sh discovered by @WenMeng-NOAA (compile_upp.sh cannot build with internal IFI due to error in argument parsing #647)
  2. An indexing error in qpf_comp in SURFCE.f causes a segfault when libIFI is used in inline post. This error is unrelated to libIFI, but somehow affects it at runtime. (Indexing error in qpf_comp causes crash in inline post when libIFI is used #648)
  3. Fix from @WenMeng-NOAA to update the version of ubuntu to run github checks (CI failures - 'Cache not found for input keys' #641)

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@SamuelTrahanNOAA Can you open a new UPP issue to link this PR?

@SamuelTrahanNOAA
Copy link
Copy Markdown
Contributor Author

Can you open a new UPP issue to link this PR?

I have given you not one, but two issues, one for each bug.

@SamuelTrahanNOAA
Copy link
Copy Markdown
Contributor Author

The Intel Linux Build / build (pull_request) step failure is unrelated to my changes:

/home/runner/.bash_profile: line 2: /opt/intel/oneapi/setvars.sh: No such file or directory

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The Intel Linux Build / build (pull_request) step failure is unrelated to my changes:

/home/runner/.bash_profile: line 2: /opt/intel/oneapi/setvars.sh: No such file or directory

Yes, this issue was addressed in #641. Could you pick up the changes from here to combine in your PR? Also sync your branch with the top of the UPP develop branch. I will process this PR first. Thanks!

@SamuelTrahanNOAA
Copy link
Copy Markdown
Contributor Author

Your fix is in the branch. We shall soon see if it works in my fork.

@SamuelTrahanNOAA
Copy link
Copy Markdown
Contributor Author

I'm seeing two warnings, but no errors yet:

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@SamuelTrahanNOAA
Copy link
Copy Markdown
Contributor Author

All of the checks are successful, so it seems the bugs are fixed. I've opened a new issue about the warnings:

#649

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@AlexanderRichert-NOAA Can you review intel.yml update regarding CI failed at intel build? Thanks!

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Contributor

@WenMeng-NOAA Yep, CI changes look good to me.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Mar 2, 2023
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on WCOSS2, Hera and Orion. No baseline update is needed with this PR.

@WenMeng-NOAA WenMeng-NOAA merged commit c82aebb into NOAA-EMC:develop Mar 2, 2023
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
…odel LBC processing (NOAA-EMC#646)

* update atmos_cubed_sphere to better handle data source for regional model LBC processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. RRFS

Projects

None yet

3 participants