Merge public v2 by fossell · Pull Request #295 · NOAA-EMC/UPP

fossell · 2021-04-09T16:22:14Z

This commit merges the release/public-v2 branch into develop and resolves Issue #295. Changes are minimal and include:

Updates to documentation files
Updating naming convention in parm/makefile to be consistent with LAM (SAR --> LAM)
Removal of community build mechanisms including removal of comlibs directory and crtm submodule
Renaming community run script to be consistent with executable name
Updates to module files for Odin and Stampede platforms

…ric example

… field for all (NOAA-EMC#170) microphysics schemes, cldfra.

Cherry-pick NOAA-EMC#170 cloud fraction mod for FV3LAM

Documentation modifications for release/public-v2

gfortran 10.x treats argument mismatch as error

Add (gnu) compiler option to allow argument mismatch. (NOAA-EMC#179)

Change nomenclature of SAR config files to use "LAM" instead of "SAR" per SRW team.

Updated support on Odin & Stampede to use NCEPLIBS public-v2 release

…consistent with other applications

…st static NetCDF libraries

…te_cmakemodules release/public-v2: fix problem linking to static NetCDF libraries

…e/public-v2

Unify the public-v2 executable name

Starting release/public-v2 branch with UPP version 9.0.0

Modified UPP stand-alone run script with name change to run_upp

…_old_comm_build

* Fix of total cloud fraction in CLDRAD.f for FV3/LAMX. * Setting iSF_SURFACE_PHYSICS as 2 in regional FV3 read interface.

Bug fix for FV3 LAM/LAMX (NOAA-EMC#219)

fossell · 2021-04-09T16:24:22Z

@ywangwof - Can you please confirm the changes you added in public-v2 for Odin and Stampede module files are still correct and should be merged into develop branch?

ywangwof · 2021-04-09T16:52:28Z

@ywangwof - Can you please confirm the changes you added in public-v2 for Odin and Stampede module files are still correct and should be merged into develop branch?

As I understand, we will not need those changes because we are using cmake to build the programs and the configuration will be handled in the SRW app level, right?

mkavulich

Looks good to me; my comments are very minor text changes, just things I noticed while reading through.

fossell · 2021-04-12T15:47:10Z

@ywangwof - Can you please confirm the changes you added in public-v2 for Odin and Stampede module files are still correct and should be merged into develop branch?

As I understand, we will not need those changes because we are using cmake to build the programs and the configuration will be handled in the SRW app level, right?

@ywangwof - Yes if using the SRW app, set up and build is handled there and via cmake. I can revert these changes then if not needed.

…v is handled at app level for these machines

fossell · 2021-04-12T19:01:24Z

@WenMeng-NOAA - Code passed reg tests on Hera. Ready for your final review.

hertneky

This looks good to me.

WenMeng-NOAA · 2021-04-13T12:46:22Z

@fossell The changes look good to me. I will schedule merging after the PR #294.

WenMeng-NOAA · 2021-04-16T20:41:33Z

@fossell It might take more time for tweaking the PR #294. I am thinking merging your PR first. Please let me know if this plan works to you.

fossell · 2021-04-19T14:21:16Z

@WenMeng-NOAA - Yes, that is fine with me. Just let me know what I can do to help.

WenMeng-NOAA · 2021-04-19T14:30:49Z

@fossell After your branch is synced, I will start to the regression tests.
Also Yali updated her current issue in the issue #272, please let us know if the DTC could help that. Thanks!

fossell · 2021-04-19T14:35:33Z

@WenMeng-NOAA - Branch has been updated.

WenMeng-NOAA · 2021-04-19T20:42:19Z

The UPP regression tests were conducted on WCOSS and Hera. No changed results were found. This PR is ready for merging.

fossell · 2021-04-22T17:57:09Z

@fossell After your branch is synced, I will start to the regression tests.
Also Yali updated her current issue in the issue #272, please let us know if the DTC could help that. Thanks!

@WenMeng-NOAA - I have not had a chance to look at issue #272. Our planning year ends next week so we are working on finishing up final tasks. But I will try to look as soon as I can.

… GSD_HRRR25km grid. (NOAA-EMC#295) ## DESCRIPTION OF CHANGES: * Add new subconus 3km grid of ESGgrid type named GSD_SUBCONUS3km. * Allow this as well as the GSD_HRRR25km, GSD_HRRR13km, and GSD_RAP13km grids to run in NCO mode. * Add new WE2E test for the GSD_SUBCONUS3km grid in NCO mode named nco_GSD_SUBCONUS3km_HRRRX_RAPX. * Add new WE2E test for the GSD_HRRR25km grid in NCO mode named nco_GSD_HRRR25km_HRRRX_RAPX. ## TESTS CONDUCTED: Ran the two new WE2E tests on hera -- nco_GSD_SUBCONUS3km_HRRRX_RAPX and nco_GSD_HRRR25km_HRRRX_RAPX. Both completed successfully. The changes do not affect any of the other WE2E tests, so those were not run.

hertneky and others added 30 commits August 17, 2020 16:33

Add grib2 output tables for MRW/SRW to InputOutput documentation

a28db0f

Include a variety of examples for regridding instead of a single gene…

491f2d2

…ric example

Minor mod to Acknowledgments

4123463

Replace cld_amt, the 3D cloud fraction from the GFDL mp with the same…

3a1595d

… field for all (NOAA-EMC#170) microphysics schemes, cldfra.

Merge pull request NOAA-EMC#177 from fossell/release/public-v2

ba89a7d

Cherry-pick NOAA-EMC#170 cloud fraction mod for FV3LAM

Merge pull request NOAA-EMC#164 from hertneky/v2_doc_mods

bacadb2

Documentation modifications for release/public-v2

Add (gnu) compiler option to allow argument mismatch. (NOAA-EMC#179)

b660c45

gfortran 10.x treats argument mismatch as error

Merge pull request NOAA-EMC#180 from fossell/release/public-v2

33fd887

Add (gnu) compiler option to allow argument mismatch. (NOAA-EMC#179)

Change control files names fv3sar->fv3lam to be in-line with SRW release

54111a6

Change flat file names fv3sar->fv3lam

b2d5abe

Merge pull request NOAA-EMC#188 from hertneky/v2_config_naming

abb393e

Change nomenclature of SAR config files to use "LAM" instead of "SAR" per SRW team.

Updated support on Odin & Stampede to use NCEPLIBS public-v2 release

0e6bdd1

Merge pull request NOAA-EMC#194 from ywangwof/release/public-v2_odin

9d4eb19

Updated support on Odin & Stampede to use NCEPLIBS public-v2 release

Change executable name of cmake build for public-v2 to be ncep_post, …

0011769

…consistent with other applications

Update submodule pointer for CMakeModules to fix linker problem again…

8c7c01f

…st static NetCDF libraries

Merge pull request NOAA-EMC#198 from climbfuji/release_public_v2_upda…

201a197

…te_cmakemodules release/public-v2: fix problem linking to static NetCDF libraries

Merge remote-tracking branch 'upstream/release/public-v2' into releas…

acc5eff

…e/public-v2

Merge pull request NOAA-EMC#197 from fossell/release/public-v2

459ad72

Unify the public-v2 executable name

Starting UPP version numbers with 10.0.0 for develop branch

0c97410

Starting release/public-v2 branch with UPP version 9.0.0

3965966

Merge pull request NOAA-EMC#203 from fossell/release/public-v2

2689a70

Starting release/public-v2 branch with UPP version 9.0.0

Remove old community build libraries and gnu make utilities

7675b82

Remove configure/compile/clean utilties for old community build

95d4ad5

Modified UPP stand-alone run script with name change to run_upp

6dd7d58

Merge pull request NOAA-EMC#214 from hertneky/v2_script_mods

c0899ed

Modified UPP stand-alone run script with name change to run_upp

Merge remote-tracking branch 'upstream/release/public-v2' into remove…

088f5fb

…_old_comm_build

Merge remote-tracking branch 'upstream/develop' into develop

b16a92f

Merge remote-tracking branch 'upstream/develop' into develop

7cd8794

Bug fix for FV3 LAM/LAMX (NOAA-EMC#219)

d3199e8

* Fix of total cloud fraction in CLDRAD.f for FV3/LAMX. * Setting iSF_SURFACE_PHYSICS as 2 in regional FV3 read interface.

Merge pull request NOAA-EMC#221 from fossell/release/public-v2

bff872f

Bug fix for FV3 LAM/LAMX (NOAA-EMC#219)

fossell added 3 commits April 9, 2021 10:00

merge public-v2

32210e2

Update CMakeModules

a80521d

remove duplicate cldfra variable accidently added in merge

388fac2

fossell requested review from WenMeng-NOAA and hertneky April 9, 2021 16:23

mkavulich approved these changes Apr 9, 2021

View reviewed changes

Comment thread docs/Installation.rst

Comment thread docs/Regridding.rst Outdated

WenMeng-NOAA linked an issue Apr 12, 2021 that may be closed by this pull request

Merge release/public-v2 #292

Closed

WenMeng-NOAA mentioned this pull request Apr 12, 2021

Can CRTM submodule be deleted? #281

Closed

Documentation updates for GNU version and minor syntax fix.

54c0d0b

fossell linked an issue Apr 12, 2021 that may be closed by this pull request

Can CRTM submodule be deleted? #281

Closed

Revert module files for Odin and Stampede per ywangwof since build en…

517dae2

…v is handled at app level for these machines

hertneky approved these changes Apr 12, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/develop' into merge_public-v2

7af20b6

WenMeng-NOAA reviewed Apr 19, 2021

View reviewed changes

Comment thread parm/makefile Outdated

remove extraneous conflict HEAD line

cf5b921

WenMeng-NOAA approved these changes Apr 19, 2021

View reviewed changes

WenMeng-NOAA merged commit 557ab31 into NOAA-EMC:develop Apr 19, 2021

WenMeng-NOAA mentioned this pull request Apr 19, 2021

Updates in branch develop #166

Closed

Conversation

fossell commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fossell commented Apr 9, 2021

Uh oh!

ywangwof commented Apr 9, 2021

Uh oh!

mkavulich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fossell commented Apr 12, 2021

Uh oh!

fossell commented Apr 12, 2021

Uh oh!

hertneky left a comment

Choose a reason for hiding this comment

Uh oh!

WenMeng-NOAA commented Apr 13, 2021

Uh oh!

WenMeng-NOAA commented Apr 16, 2021

Uh oh!

fossell commented Apr 19, 2021

Uh oh!

WenMeng-NOAA commented Apr 19, 2021

Uh oh!

fossell commented Apr 19, 2021

Uh oh!

Uh oh!

WenMeng-NOAA commented Apr 19, 2021

Uh oh!

fossell commented Apr 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fossell commented Apr 9, 2021 •

edited

Loading