Cherry-pick #170 cloud fraction mod for FV3LAM#177
Merged
Conversation
… field for all (NOAA-EMC#170) microphysics schemes, cldfra.
ericaligo-NOAA
approved these changes
Aug 27, 2020
Contributor
ericaligo-NOAA
left a comment
ericaligo-NOAA
left a comment
There was a problem hiding this comment.
cld_amt was read in from the dyn file, but since that will be replaced by cldfra, which is read in from the phy file, we read in one less record (14 not 15) and we can eliminate the read of cld_amt.
Contributor
Author
|
@JeffBeck-NOAA - Did you or anyone else want to review this or are we good to go with merging in Eric's mods? |
Contributor
|
@fossell Based on the email threads I've reviewed, I think we're ready to merge! |
Contributor
Author
|
@JeffBeck-NOAA Great, thanks for confirming! |
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #170 mods to the release/public-v2 branch for SRW release. @ericaligo-NOAA - Can you please confirm your mods need to go into this branch/release? If yes, does this need to be tested by SRW team prior to merging this PR?