Thread-safe calculations for USWRF, SDEN

sorc/ncep_post.fd/CLDRAD.f

@@ -3813,7 +3813,7 @@ SUBROUTINE CLDRAD
 !     CURRENT OUTGOING SW RADIATION AT THE SURFACE.
       IF (IGET(141)>0) THEN
         GRID1 = spval
-!$omp parallel do private(i,j)
+!$omp parallel do private(i,j,FACTRS)
         DO J=JSTA,JEND
           DO I=ISTA,IEND
             IF(RSWOUT(I,J)<SPVAL) THEN
@@ -3936,7 +3936,7 @@ SUBROUTINE CLDRAD
 !     CURRENT (instantaneous) INCOMING CLEARSKY SW RADIATION AT THE SURFACE.
       IF (IGET(262)>0) THEN
          GRID1 = spval
-!$omp parallel do private(i,j)
+!$omp parallel do private(i,j,FACTRS)
          DO J=JSTA,JEND
            DO I=ISTA,IEND
             IF(RSWINC(I,J)<SPVAL) THEN

sorc/ncep_post.fd/UPP_PHYSICS.f

@@ -5154,7 +5154,7 @@ subroutine calslr_uutah2(slr)
 
       slr = spval
 
-!$omp parallel do private(i,j)      
+!$omp parallel do private(i,j,swnd)      
       do j=jsta,jend
       do i=ista,iend
       if(zsfc(i,j)<spval) then

tests/logs/rt.log.HERCULES_intel

@@ -1,63 +1,63 @@
 ===== Start of UPP Regression Testing Log =====
 UPP Hash Tested:
-0ff195dee97b1b650c759fd80b9201f0b2659ddc
+98bbd7664216c8d31a207f152853c57c6e4670a2
 
 Submodule hashes:
 -5afd607642ae0fd6a53b137230336386beb47ce6 sorc/libIFI.fd
 -3d35332fe66e3e63a285cc8d96facdf255a33481 sorc/ncep_post.fd/post_gtg.fd
 
-Run directory: /work2/noaa/epic/clyden/regression-tests/upp/hercules/1393_hercules_intel/ci/rundir/upp-HERCULES
+Run directory: /work2/noaa/epic/clyden/regression-tests/upp/hercules/1402_hercules_intel/ci/rundir/upp-HERCULES
 Baseline directory: /work/noaa/epic/role-epic/hercules/UPP
 
-Total runtime: 00h:11m:50s
-Test Date: 20260109 07:17:20
+Total runtime: 00h:10m:14s
+Test Date: 20260114 08:44:54
 Summary Results:
 
-01/09 13:07:40Z -sfs test: your new post executable generates bit-identical sfs.t00z.master.grb2f048 as the develop branch
-01/09 13:07:43Z -aqm test: your new post executable generates bit-identical CMAQ08.tm00 as the develop branch
-01/09 13:07:50Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
-01/09 13:08:05Z -hafs test: your new post executable generates bit-identical HURPRS09.tm00 as the develop branch
-01/09 13:08:17Z -gefsv13 test: your new post executable generates bit-identical gefs.t00z.master.grb2f009 as the develop branch
-01/09 13:08:33Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF06 as the develop branch
-01/09 13:08:34Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
-01/09 13:08:37Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the develop branch
-01/09 13:08:37Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the develop branch
-01/09 13:08:37Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
-01/09 13:08:45Z -mpas test: your new post executable generates bit-identical POSTNAT18.tm00 as the develop branch
-01/09 13:08:46Z -mpas test: your new post executable generates bit-identical POSTPRS18.tm00 as the develop branch
-01/09 13:08:46Z -mpas test: your new post executable generates bit-identical POSTTWO18.tm00 as the develop branch
-01/09 13:09:20Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
-01/09 13:09:21Z -3drtma test: your new post executable generates bit-identical WRFTWO.GrbF00 as the develop branch
-01/09 13:09:21Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
-01/09 13:09:25Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF10 as the develop branch
-01/09 13:09:26Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
-01/09 13:09:26Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
-01/09 13:09:31Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
-01/09 13:09:33Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
-01/09 13:09:33Z -mpas_hfip test: your new post executable generates bit-identical 2DFLD.GrbF48 as the develop branch
-01/09 13:09:52Z -rrfs_ifi_missing test: your new post executable generates bit-identical IFIFIP18.tm00 as the develop branch
-01/09 13:10:10Z -gcafs test: your new post executable generates bit-identical GFSPRS.GrbF60 as the develop branch
-01/09 13:10:11Z -gcafs test: your new post executable generates bit-identical GFSFLX.GrbF60 as the develop branch
-01/09 13:14:04Z -rrfs test: your new post executable generates bit-identical PRSLEV18.tm00 as the develop branch
-01/09 13:14:14Z -rrfs test: your new post executable generates bit-identical NATLEV18.tm00 as the develop branch
-01/09 13:17:12Z -gfs test: your new post executable generates bit-identical gfs.t00z.master.grb2f006 as the develop branch
-01/09 13:17:12Z -gfs test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the develop branch
-01/09 13:17:12Z -gfs test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the develop branch
-01/09 13:08:04Z -Runtime: sfs_test 00:00:05 -- baseline 00:01:20
-01/09 13:08:04Z -Runtime: aqm_test 00:00:08 -- baseline 00:00:30
-01/09 13:08:04Z -Runtime: gefsv12_test 00:00:15 -- baseline 00:01:00
-01/09 13:08:19Z -Runtime: gefsv13_test 00:00:42 -- baseline 00:02:00
-01/09 13:08:49Z -Runtime: nmmb_test 00:01:02 -- baseline 00:03:00
-01/09 13:08:49Z -Runtime: rap_test 00:00:59 -- baseline 00:02:00
-01/09 13:09:35Z -Runtime: hrrr_test 00:01:51 -- baseline 00:06:00
-01/09 13:09:35Z -Runtime: hafs_test 00:00:30 -- baseline 00:01:00
-01/09 13:09:35Z -Runtime: 3drtma_test 00:01:46 -- baseline 00:03:00
-01/09 13:09:35Z -Runtime: mpas_test 00:01:11 -- baseline 00:02:30
-01/09 13:09:35Z -Runtime: mpas_hfip_test 00:01:59 -- baseline 00:05:00
-01/09 13:10:20Z -Runtime: gcafs_test 00:02:36 -- baseline 00:02:30
-01/09 13:14:20Z -Runtime: rrfs_test 00:06:39 -- baseline 00:12:00
-01/09 13:14:20Z -Runtime: rrfs_ifi_missing 00:02:17 -- baseline 00:04:00
-01/09 13:17:20Z -Runtime: gfs_test 00:09:37 -- baseline 00:25:00
+01/14 14:37:12Z -sfs test: your new post executable generates bit-identical sfs.t00z.master.grb2f048 as the develop branch
+01/14 14:37:14Z -aqm test: your new post executable generates bit-identical CMAQ08.tm00 as the develop branch
+01/14 14:37:21Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
+01/14 14:37:38Z -hafs test: your new post executable generates bit-identical HURPRS09.tm00 as the develop branch
+01/14 14:37:50Z -gefsv13 test: your new post executable generates bit-identical gefs.t00z.master.grb2f009 as the develop branch
+01/14 14:38:04Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF06 as the develop branch
+01/14 14:38:04Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
+01/14 14:38:09Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the develop branch
+01/14 14:38:10Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the develop branch
+01/14 14:38:10Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
+01/14 14:38:18Z -mpas test: your new post executable generates bit-identical POSTNAT18.tm00 as the develop branch
+01/14 14:38:19Z -mpas test: your new post executable generates bit-identical POSTPRS18.tm00 as the develop branch
+01/14 14:38:19Z -mpas test: your new post executable generates bit-identical POSTTWO18.tm00 as the develop branch
+01/14 14:38:50Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
+01/14 14:38:50Z -3drtma test: your new post executable generates bit-identical WRFTWO.GrbF00 as the develop branch
+01/14 14:38:51Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
+01/14 14:39:01Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF10 as the develop branch
+01/14 14:39:01Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
+01/14 14:39:02Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
+01/14 14:39:03Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
+01/14 14:39:05Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
+01/14 14:39:05Z -mpas_hfip test: your new post executable generates bit-identical 2DFLD.GrbF48 as the develop branch
+01/14 14:39:30Z -rrfs_ifi_missing test: your new post executable generates bit-identical IFIFIP18.tm00 as the develop branch
+01/14 14:39:42Z -gcafs test: your new post executable generates bit-identical GFSPRS.GrbF60 as the develop branch
+01/14 14:39:43Z -gcafs test: your new post executable generates bit-identical GFSFLX.GrbF60 as the develop branch
+01/14 14:43:19Z -rrfs test: your new post executable generates bit-identical PRSLEV18.tm00 as the develop branch
+01/14 14:43:30Z -rrfs test: your new post executable generates bit-identical NATLEV18.tm00 as the develop branch
+01/14 14:44:42Z -gfs test: your new post executable generates bit-identical gfs.t00z.master.grb2f006 as the develop branch
+01/14 14:44:44Z -gfs test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the develop branch
+01/14 14:44:44Z -gfs test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the develop branch
+01/14 14:37:36Z -Runtime: sfs_test 00:00:07 -- baseline 00:01:20
+01/14 14:37:36Z -Runtime: aqm_test 00:00:08 -- baseline 00:00:30
+01/14 14:37:36Z -Runtime: gefsv12_test 00:00:15 -- baseline 00:01:00
+01/14 14:37:51Z -Runtime: gefsv13_test 00:00:44 -- baseline 00:02:00
+01/14 14:38:22Z -Runtime: nmmb_test 00:01:04 -- baseline 00:03:00
+01/14 14:38:22Z -Runtime: rap_test 00:00:55 -- baseline 00:02:00
+01/14 14:39:07Z -Runtime: hrrr_test 00:01:53 -- baseline 00:06:00
+01/14 14:39:07Z -Runtime: hafs_test 00:00:29 -- baseline 00:01:00
+01/14 14:39:07Z -Runtime: 3drtma_test 00:01:42 -- baseline 00:03:00
+01/14 14:39:07Z -Runtime: mpas_test 00:01:10 -- baseline 00:02:30
+01/14 14:39:07Z -Runtime: mpas_hfip_test 00:01:57 -- baseline 00:05:00
+01/14 14:39:53Z -Runtime: gcafs_test 00:02:34 -- baseline 00:02:30
+01/14 14:43:38Z -Runtime: rrfs_test 00:06:21 -- baseline 00:12:00
+01/14 14:43:39Z -Runtime: rrfs_ifi_missing 00:02:21 -- baseline 00:04:00
+01/14 14:44:54Z -Runtime: gfs_test 00:07:35 -- baseline 00:25:00
 Check tests:
 ['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'rrfs_ifi_missing', 'gfs']
 No changes in test results detected.