Thread-safe calculations for USWRF, SDEN#1402
Merged
BenjaminBlake-NOAA merged 8 commits intoJan 14, 2026
Merged
Conversation
NickSzapiro-NOAA
requested review from
BenjaminBlake-NOAA and
WenMeng-NOAA
as code owners
BenjaminBlake-NOAA
added
Ready for Review
Collaborator
|
@clyden-noaa This PR is ready for testing on the RDHPCs. No baseline changes are expected. Thanks! |
clyden-noaa
approved these changes
Jan 14, 2026
Collaborator
clyden-noaa
left a comment
clyden-noaa
left a comment
There was a problem hiding this comment.
@WenMeng-NOAA @BenjaminBlake-NOAA @NickSzapiro-NOAA
My testing is now complete.
The RTs ran successfully without errors and finished within established timing thresholds on all RDHPC systems.
There were no baseline changes, as expected
WenMeng-NOAA
approved these changes
Jan 14, 2026
BenjaminBlake-NOAA
approved these changes
Jan 14, 2026
Collaborator
BenjaminBlake-NOAA
left a comment
BenjaminBlake-NOAA
left a comment
There was a problem hiding this comment.
Testing is complete and this PR is ready for merging.
This was referenced Jan 20, 2026
DusanJovic-NOAA
pushed a commit
to NOAA-EMC/ufsatm
that referenced
this pull request
Jan 28, 2026
Update the UPP hash for the production/GFS.v17 branch (named release/gfs_v17) in the UFSATM production/GFS.v17 branch. Included is a fix to a race condition (NOAA-EMC/UPP#1413) that is also now included at the head of UPP develop (NOAA-EMC/UPP#1402) and will be added to the UFSWM develop branch.
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix thread-safety issues in calculations for RSWOUT, RSWINC, SLR by making previously shared real variables thread-private
Closes #1398