Skip to content

Update NEMS for CDEPS component #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MinsukJi-NOAA merged 7 commits into from
May 5, 2021
Merged

Update NEMS for CDEPS component #92

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1b4a5bf
Revised module_EARTH_GRID_COMP.F90 for datm_cfsr and datm_gefs compon…
binli2337 Mar 4, 2021
5e75382
Revised module_EARTH_GRID_COMP.F90.
binli2337 Mar 21, 2021
fc4308c
Updated module_EARTH_GRID_COMP.F90.
binli2337 Mar 23, 2021
62364ab
Merge branch 'develop' into feature/new_cdeps
binli2337 Apr 15, 2021
ca47b0a
Merge branch 'develop' into feature/new_cdeps
binli2337 Apr 25, 2021
8622809
Merge branch 'develop' into feature/new_cdeps
binli2337 Apr 28, 2021
6a78eec
Merge branch 'develop' into feature/new_cdeps
binli2337 May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/module_EARTH_GRID_COMP.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ MODULE module_EARTH_GRID_COMP
#endif
#ifdef FRONT_DATM
use FRONT_DATM, only: DATM_SS => SetServices
#endif
#ifdef FRONT_CDEPS_DATM
use FRONT_CDEPS_DATM, only: DATM_SS => SetServices
#endif
! - Handle build time OCN options:
#ifdef FRONT_SOCN
Expand Down Expand Up @@ -3596,8 +3599,9 @@ subroutine SetModelServices(driver, rc)
file=__FILE__, rcToReturn=rc)
return ! bail out
#endif
elseif (trim(model) == "datm") then
#ifdef FRONT_DATM
elseif (trim(model) == "datm" .or. trim(model) == "datm_cfsr" .or. &

@uturuncoglu uturuncoglu Mar 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these CDEPS data atmosphere? I think this implementation is not flexible enough because you need to add a line for each specific datm stream. At this level model only need to know the datm not the stream used in CDEPS. So, only datm is enough for driver at this point. Please refer to following version of the file found in hafs-community#3

@rsdunlapiv rsdunlapiv Mar 18, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to remove datm_cfsr and datm_gefs because the way to configure the DATM input data is via its namelist. Moreover, the driver does not need to know what the source of the data is. Also, this approach means we'd need to change the driver to add a new data source to CDEPS. All good reasons why we only need DATM at the driver level. This is important to get right.

@DeniseWorthen DeniseWorthen Mar 18, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsdunlapiv So you're saying that nems.configure will have the atm model either datm (=nemsdatm), datm_cfsr (=cdeps,cfsr source) or datm_gefs (cdeps,gefs source). There is nothing in the driver it self that is needed to distinguish those options.

trim(model) == "datm_gefs") then

@uturuncoglu uturuncoglu Mar 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is same with the previous one.

#if defined FRONT_DATM || defined FRONT_CDEPS_DATM
call NUOPC_DriverAddComp(driver, trim(prefix), DATM_SS, &
petList=petList, comp=comp, rc=rc)
if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, &
Expand Down