Skip to content

Fix divide by zero fpe in apply_oda_incupd #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiandewang merged 1 commit into from
Oct 24, 2025
Merged

Fix divide by zero fpe in apply_oda_incupd #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/ocean_data_assim/MOM_oda_incupd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,19 +599,19 @@ subroutine apply_oda_incupd(h, tv, u, v, dt, G, GV, US, CS)
tmp_val1(:) = 0.0
tmp_t(:,:,:) = 0.0 ; tmp_s(:,:,:) = 0.0 ! diagnostics
do j=js,je ; do i=is,ie
! account for the different SSH
sum_h1 = 0.0
do k=1,nz
sum_h1 = sum_h1+h(i,j,k)
enddo
sum_h2 = 0.0
do k=1,nz_data
sum_h2 = sum_h2+h_obs(i,j,k)
enddo
do k=1,nz_data
tmp_h(k) = ( sum_h1 / sum_h2 ) * h_obs(i,j,k)
enddo
if (G%mask2dT(i,j) == 1) then
! account for the different SSH
sum_h1 = 0.0
do k=1,nz
sum_h1 = sum_h1+h(i,j,k)
enddo
sum_h2 = 0.0
do k=1,nz_data
sum_h2 = sum_h2+h_obs(i,j,k)
enddo
do k=1,nz_data
tmp_h(k) = ( sum_h1 / sum_h2 ) * h_obs(i,j,k)
enddo
! get temperature increment
do k=1,nz_data
tmp_val2(k) = CS%Inc(1)%p(i,j,k)
Expand Down