Fix divide by zero fpe in apply_oda_incupd#164
Merged
jiandewang merged 1 commit intoOct 24, 2025
Conversation
Move computation of tmp_h inside the if G%mask2dT test to avoid divide by zero error
33 tasks
Collaborator
|
@sanAkel one more PR to review, it looks good to me. Can you check it ? |
Collaborator
|
@DusanJovic-NOAA this PR will not change baseline, right ? |
Author
Correct. |
Collaborator
|
@DusanJovic-NOAA and @jiandewang some effort must be spent on tracing the origins of why those aforementioned divide by zeros are happening; suggestion follows. |
sanAkel
approved these changes
Oct 11, 2025
Collaborator
There was a problem hiding this comment.
Following this conversation this is a safe addition.
Suggestion:
Plot (spatial map) of locations of where the crash happens.
jiandewang
approved these changes
Oct 12, 2025
22 tasks
|
All tests have passed on the WM side for parent PR #2932. We can go ahead with the merge process here. |
|
All tests were done ok at ufs-community/ufs-weather-model#2932. @sanAkel @jiandewang can you merge this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move computation of tmp_h inside the if G%mask2dT test to avoid divide by zero error.
See ufs-community/ufs-weather-model#2906 for details.