Changes to add NOAA-21 and GOES-18 radiances in monitor mode by ADCollard · Pull Request #636 · NOAA-EMC/GSI

ADCollard · 2023-10-04T17:16:48Z

Turn on NOAA-21 and GOES-19 radiances in operations in monitoring mode.

scripts/exglobal_atmos_analysis.sh: Add processing of GOES-18 CSRs, NOAA-21 ATMS and CrIS
fix/global_anavinfo.l127.txt: Point to new file, Rcov_crisn21
fix/global_satinfo.txt: Down weighted NOAA-21 CrIS radiances relative to NOAA-20
fix/Rcov_crisn21: New file

The fix branch is DA_GFSv16.3.9_global_only

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
New and existing tests pass with my changes
Any dependent changes have been merged and published

emilyhcliu · 2023-10-04T18:06:41Z

   ahibufr        ahi         himawari8   ahi_himawari8       0.0     1     0
   abibufr        abi         g16         abi_g16             0.0     1     0
   abibufr        abi         g17         abi_g17             0.0     1     0
+   abibufr        abi         g18         abi_g18             0.0     1     0


Will we assimilate ABI g18 clear-sky radiance?
Or, this is a place holder?

emilyhcliu · 2023-10-04T18:08:04Z

   ahibufr        ahi         himawari9   ahi_himawari9       0.0     1     0
   sstviirs       viirs-m     j2          viirs-m_j2          0.0     4     0
+   atmsbufr21     atms        n21         atms_n21            0.0     1     0
+   crisfsbufr21   cris-fsr    n21         cris-fsr_n21        0.0     1     0


ATMS N21 will be assimilated and the CrIS N21 is a place holder, correct?

I can not see the fix files from the github page. I believe that the use flag for ATMS N21 is set to 1, and the use flags for CrIS-fsr N21 and ABI-g18 are set to -1

I think we already made changes in abias and abias_pc for the three sensors in v16.3. implementation.

@emilyhcliu, I cloned ADCollard:release/gfsda.v16. A check of fix/global_satinfo.txt shows that the usage flags for atms_n21, cris-fsr_n21, and abi_g18 are -1 for all channels.

@ADCollard , the PR description indicates that we should see changes in fix/global_anavinfo.l127.txt. This file is identical between ADCollard:release/gfsda.v16 and NOAA-EMC:release/gfsda.v16.

Should we also see a difference between cris-fsr_n21 weights when comparing global_satinfo.txt from ADCollard:release/gfsda.v16 and NOAA-EMC:release/gfsda.v16?

Thanks @RussTreadon-NOAA
@ADCollard did mention that the purpose of this PR is to set CrIS N21, ATMS N21, and ABI G18 to monitoring mode in the description section of this PR.
So, the use flags for these three sensors should be -1 and they are set correctly in this PR.

Yes, both current operations, gfs.v16.3.9, and this PR maintain all channels of atms_n21, cris-fsr_n21, and abi_g18 in monitor mode.

The only difference between ADCollard:release/gfsda.v16/fix and /lfs/h1/ops/prod/packages/gfs.v16.3.9/fix/fix_gsi is the addition of Rcov_crisn21 in ADCollard:release/gfsda.v16/fix

@RussTreadon-NOAA @emilyhcliu Sorry, I was in a meeting. Yes, all three instruments need to be in monitor mode to facilitate bias correction spin-up.

@ADCollard , the PR description indicates that we should see changes in fix/global_anavinfo.l127.txt. This file is identical between ADCollard:release/gfsda.v16 and NOAA-EMC:release/gfsda.v16.

Should we also see a difference between cris-fsr_n21 weights when comparing global_satinfo.txt from ADCollard:release/gfsda.v16 and NOAA-EMC:release/gfsda.v16?

@RussTreadon-NOAA If there are no changes for fix/global_anavinfo.l127.txt and fix/global_satinfo.txt, I must have made a mistake. Let me double-check. (My github/Gerrit skills need some work)

ADCollard · 2023-10-04T19:13:16Z

@RussTreadon-NOAA @emilyhcliu The changes for fix/global_anavinfo.l127.txt and fix/global_satinfo.txt should both be in the branch now

RussTreadon-NOAA · 2023-10-04T19:26:26Z

I refreshed my working copy of ADCollard:release/gfsda.v16. File global_anavinfo.txt now contains an entry for Rcov_crisn21. File global_satinfo.txt now contains different values for error and ermax for some but not all cris-fsr_n21 channels.

The ADCollard:release/gfsda.v16 global_satinfo.txt file contains one additional change. The first line of global_satinfo.txt is missing the leading ! which is found in the operational global_satinfo.txt

russ.treadon@clogin09:/lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/gfsda.v16.3.10> diff fix/global_satinfo.txt /lfs/h1/ops/prod/packages/gfs.v16.3.9
/fix/fix_gsi/global_satinfo.txt |head -4
1c1
< sensor/instr/sat      chan iuse  error  error_cld  ermax   var_b    var_pg  icld_det icloud iaerosol
---
> !sensor/instr/sat      chan iuse  error  error_cld  ermax   var_b    var_pg  icld_det icloud iaerosol

The leading ! is used to indicate lines to skip over when reading info files. For example, radinfo.f90 contains

    open(lunin,file='satinfo',form='formatted')
    j=0
    nlines=0
    read1:  do
       read(lunin,100,iostat=istat) cflg,crecord
       if (istat /= 0) exit
       nlines=nlines+1
       if (cflg == '!') cycle
       read(crecord,*,iostat=istat) nusis_temp,nuchan_temp,iuse_rad_temp,&
            varch_temp,varch_cld_temp,ermax_rad_temp,b_rad_temp,pg_rad_temp,icld_det_temp

RussTreadon-NOAA · 2023-10-04T19:46:21Z

Refreshed working copy of ADCollard:release/gfsda.v16. The first line of fix/global_satinfo.txt now contains a leading !

ADCollard · 2023-10-04T19:48:51Z

Refreshed working copy of ADCollard:release/gfsda.v16. The first line of fix/global_satinfo.txt now contains a leading !

Thanks for spotting that @RussTreadon-NOAA !

HaixiaLiu-NOAA · 2023-10-05T01:17:26Z

After getting the fix directory to my stmp space, I checked the global_satinfo.txt, global_anavinfo.l127.txt. Both are correct. The Rcov_crisn21 is a new filed in the fix directory. All changes look good to me.

HaixiaLiu-NOAA

all changes are good to go.

RussTreadon-NOAA · 2023-10-05T10:25:42Z

@emilyhcliu , when you have a chance would you please review this PR (#636) from @ADCollard

ADCollard · 2023-10-05T11:50:30Z

One remaining change was required. HIRS processing is removed as the HIRS CRTM coefficient files' version numbers are not correct (and the code changes required for NOAA-21 ATMS exposes this). More details on this here. We do not currently assimilate HIRS.

emilyhcliu

Changes look good to me.

RussTreadon-NOAA · 2023-10-05T13:12:14Z

@ADCollard , we have two peer review approvals. Do you have any more changes for ADCollard:release/gfsda.v16?

Once I get the green light from you, I will merge ADCollard:release/gfsda.v16 into NOAA-EMC:release/gfsda.v16 and create tag gfsda.v16.3.10.

ADCollard · 2023-10-05T13:57:56Z

@RussTreadon-NOAA Thanks! Please proceed.

Changes to add NOAA-21 and GOES-18 radiances in monitor mode

c360453

ADCollard requested review from HaixiaLiu-NOAA and emilyhcliu October 4, 2023 17:16

emilyhcliu reviewed Oct 4, 2023

View reviewed changes

Additional changes for CrIS N21

77188a3

Reinstate the exclamation point

66be004

HaixiaLiu-NOAA approved these changes Oct 5, 2023

View reviewed changes

Remove HIRS processing

cf29fa1

emilyhcliu approved these changes Oct 5, 2023

View reviewed changes

RussTreadon-NOAA merged commit 3fc1ce6 into NOAA-EMC:release/gfsda.v16 Oct 5, 2023

This was referenced Oct 10, 2023

Add GFS v16.3.12 changes to develop #640

Closed

Add GFS v16.3.12 fix file updates to develop NOAA-EMC/GSI-fix#11

Closed

Add GFS v16.3.11[12] changes to develop NOAA-EMC/global-workflow#1918

Closed

KateFriedman-NOAA mentioned this pull request Oct 10, 2023

GFS.v16.3.11 - Enable the monitoring of NOAA-21 and GOES-18 radiances NOAA-EMC/global-workflow#1356

Closed

15 tasks

RussTreadon-NOAA mentioned this pull request Dec 21, 2023

spack-stack-1.6.0 release candidate available on Hercules for testing JCSDA/spack-stack#922

Closed

Conversation

ADCollard commented Oct 4, 2023

Uh oh!

emilyhcliu Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

emilyhcliu Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

emilyhcliu Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

RussTreadon-NOAA Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

emilyhcliu Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RussTreadon-NOAA Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

ADCollard Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

ADCollard Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

ADCollard commented Oct 4, 2023

Uh oh!

RussTreadon-NOAA commented Oct 4, 2023

Uh oh!

RussTreadon-NOAA commented Oct 4, 2023

Uh oh!

ADCollard commented Oct 4, 2023

Uh oh!

HaixiaLiu-NOAA commented Oct 5, 2023

Uh oh!

HaixiaLiu-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

RussTreadon-NOAA commented Oct 5, 2023

Uh oh!

ADCollard commented Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emilyhcliu left a comment

Choose a reason for hiding this comment

Uh oh!

RussTreadon-NOAA commented Oct 5, 2023

Uh oh!

ADCollard commented Oct 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

emilyhcliu Oct 4, 2023 •

edited

Loading

ADCollard commented Oct 5, 2023 •

edited

Loading