Release/gfsda.v16.0.0 restructure#39
Conversation
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Assuming these changes have been tested in a parallel using an official v16 parallel as the control and it was found that the changes do not alter analysis results, these changes can and should be merged into release/gfsda.v16.0.0.
Please consider asking Ed Safford to review changes to Monitoring j-jobs.
|
@RussTreadon-NOAA I was able to reproduce v16rt2 in my initial test but will run a fresh one with my forks and new warm starts today to reconfirm. I synced my GSI fork today with the main release/gfsda.v16.0.0 branch before submitting the PR. Will update this issue with results. @EdwardSafford-NOAA Please review the changes in this PR for the monitoring scripts. Let me know if you have any questions. Thanks! |
EdwardSafford-NOAA
left a comment
EdwardSafford-NOAA
left a comment
There was a problem hiding this comment.
Looks ok to me. Just for my edification, what are the other (or anticipated) values of $COMPONENT beyond the default atmos?
|
I believe that for v16 COMPONENT = "atmos" or "wave". See global-workflow
issue #94 <NOAA-EMC/global-workflow#94> for
details.
…On Mon, Jul 20, 2020 at 12:41 PM Ed Safford ***@***.***> wrote:
***@***.**** approved this pull request.
Looks ok to me. Just for my edification, what are the other (or
anticipated) values of $COMPONENT beyond the default atmos?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGNN635A62E5IIVL5DS24F3R4RXUXANCNFSM4PCM3S6A>
.
|
|
What Russ stated is correct. The values of COMPONENT for v16 will be either "atmos" or "wave". Future versions of the system (e.g. v17+) will begin to incorporate additional components (e.g. "ocean", "ice", etc.). |
…lease/gfsda.v16.0.0-restructure
|
Sync merged NOAA-EMC/GSI release/gfsda.v16.0.0 into KateFriedman-NOAA/GSI release/gfsda.v16.0.0-restructure at 263c10a. |
…lease/gfsda.v16.0.0-restructure
|
Committed small text fix to JGDAS_VMINMON to resolve duplicate atmos in path. Committed at aff4da8. Sync merged NOAA-EMC/GSI release/gfsda.v16.0.0 into KateFriedman-NOAA/GSI release/gfsda.v16.0.0-restructure at b53db5d. @EdwardSafford-NOAA Please see the following on Mars to confirm the monitoring jobs ran correctly, thanks! log (starting lines 1347, 15388, 16636): /gpfs/dell3/ptmp/Kate.Friedman/comrot/v16atmos2/logs/2020072100/gdasvrfy.log |
|
Looks OK to me. |
|
Great, thanks for checking and confirming @EdwardSafford-NOAA ! |
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Assuming the parallel testing these changes on Mars reproduced the control these changes may be approved.
Russ, yes, using inputs from the v16rt2 parallel I was able to run a full cycle and reproduce it with global-workflow feature/gfsv16b-restructure and the modified GSI release/gfsda.v16.0.0 fork of mine. Thanks for your help ironing out the differences caused due to resource settings! |
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Changes confirmed to reproduce control. Approve.
…lease/gfsda.v16.0.0-restructure
…lease/gfsda.v16.0.0-restructure * upstream/release/gfsda.v16.0.0: Add in some useful print statements
|
Venus v16rt2atmos2 test indicates DA updates are working. Will go ahead and merge PR #39 into release/gfsda.v16.0.0. |
3 participants
Add new $COMPONENT subdirectory to scripts to support GFSv16 restructuring. New subdirectory called "atmos" for atmospheric component.
Documented in global-workflow issue: NOAA-EMC/global-workflow#94