Update fms_mixedmode to gfdl_atmos_cubed_sphere/dev/emc#61
Merged
MinsukJi-NOAA merged 43 commits intoNov 10, 2021
Conversation
…tmos_cubed_sphere into udhmhj.04 fix conflicts.
…ed_sphere into udhmhj.04 merge without conflict
resolve conflicts. Conflicts: driver/fvGFS/atmosphere.F90 model/dyn_core.F90 model/fv_arrays.F90 model/fv_control.F90 model/fv_dynamics.F90 model/fv_mapz.F90 model/nh_utils.F90 model/sw_core.F90 model/tp_core.F90 tools/fv_diagnostics.F90
…ption and other modifications
…n be fixed by using -O0 instead of -O2 to compile fv_diagnostics.F90
Add WAM molecular diffusion
* Updates to allow for JEDI to specify input.nml
Collaborator
Author
|
I am not sure why all these very old commits (code changes) show up. I checked noaa-gfdl/gfdl_atmos_cubed_sphere/tree/dev/emc, and these commits are indeed there (see, for example, NOAA-GFDL@571bff1), but are not there in noaa-emc/gfdl_atmos_cubed_sphere/tree/fms_mixedmode. |
junwang-noaa
approved these changes
Nov 9, 2021
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
The code updates look good to me. Have you tested the mixed mode coupled run with your branch?
Collaborator
Author
I plan to test the latest ufs-weather-model with mixed mode FMS. Is there a reason for NOAA-EMC/fv3atm develop not pointing to the top of https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/tree/dev/emc? |
Collaborator
|
We were supposed to. The commit in the latest dev/emc has no impact on the
results.
…On Tue, Nov 9, 2021 at 1:28 PM Minsuk Ji ***@***.***> wrote:
The code updates look good to me. Have you tested the mixed mode coupled
run with your branch?
I plan to test the latest ufs-weather-model with mixed mode FMS.
Is there a reason for NOAA-EMC/fv3atm
<https://github.com/NOAA-EMC/fv3atm/tree/develop> not pointing to the top
of https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/tree/dev/emc.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TOMMNOJE6ABEJ2556DULFR4FANCNFSM5HV3TRAA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
binli2337
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.