Skip to content

Feature/jedi control#136

Merged
laurenchilutti merged 6 commits into
NOAA-GFDL:dev/emcfrom
mark-a-potts:feature/jedi-control
Oct 27, 2021
Merged

Feature/jedi control#136
laurenchilutti merged 6 commits into
NOAA-GFDL:dev/emcfrom
mark-a-potts:feature/jedi-control

Conversation

@mark-a-potts
Copy link
Copy Markdown

@mark-a-potts mark-a-potts commented Sep 3, 2021

Small changes that allow a coupled system to request the namelist read be skipped or given a different name.

Fixes # (issue)

How Has This Been Tested?

This PR has been tested against both JEDI-controlled UFS forecasts and UFS forecasts without JEDI control and works as expected.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@mark-a-potts mark-a-potts marked this pull request as ready for review October 26, 2021 14:14
@bensonr
Copy link
Copy Markdown
Contributor

bensonr commented Oct 26, 2021

@mark-a-potts - we should have a live conversation to discuss to ensure the behavior of this section of code is as you expect it to be.

@mark-a-potts
Copy link
Copy Markdown
Author

Sure thing. I was trying to figure out who was actually going to review this.

@mark-a-potts
Copy link
Copy Markdown
Author

@mark-a-potts - we should have a live conversation to discuss to ensure the behavior of this section of code is as you expect it to be.

Do you have time to go over this today? If so, I can schedule a google meet.

@bensonr
Copy link
Copy Markdown
Contributor

bensonr commented Oct 27, 2021 via email

@laurenchilutti
Copy link
Copy Markdown
Member

@mark-a-potts Could you also include me on this meeting? I am also available at those times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants