Stand alone script to run a single atm 3DVar analysis#42
Conversation
|
Note @FanHan-NOAA you might want to try being a beta tester here to clone, build, and run this single script, as it will help with your interpolation work for the ISDA conference. |
| batch_script = os.path.join(working_dir, 'submit_job.sh') | ||
| with open(batch_script, 'w') as f: | ||
| f.write('#!/bin/bash\n') | ||
| if job_config['machine'] in ['orion', 'hera']: |
There was a problem hiding this comment.
I would suggest using scheduler instead of machine where these kind of decisions need to be made.
There was a problem hiding this comment.
Yeah I thought about that, but wanted to make it simpler for the user. Should I do the workflow approach where scheduler is the if statement but it is determined based on a dict (if scheduler[job_config['machine']] == 'slurm')?
Great! Thanks for this addition. I'll start testing it soon. |
|
@CoryMartin-NOAA : As we review this PR shall we ignore, for the the time being, pieces specific to Hera and focus solely on Orion? |
|
@RussTreadon-NOAA I'm open to see what you and others think. Currently this will only work on Orion, as I need to stage fix files and a R2D2 database on Hera. Does it make sense to support both systems now, or focus on Orion and port when things have stabilized slightly? |
|
@CoryMartin-NOAA, I agree with you. To keep things moving focus on Orion and port when GDASApp has stabilized. |
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Successfully installed and ran run_single_atm_var_analysis.py on Orion. The description for PR #42 provides a sample.yaml. Should we commit a templated sample.yaml to feature/single_anl?
I was actually thinking the next step is to add a "regression test" that would do a nccmp on the increment file and compare it to the existing increment file and determine if the analysis still is produced. That way the regression test would hold the sample YAML file, but I can alternatively create a |
|
Automated Pull Request Testing Results: |
What you outline is feasible. This will provide users with an example of what |
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Thank you, @CoryMartin-NOAA , for answering my questions. The changes look good to me.
I see that you are working with @aerorahul regarding scheduler in ush/ufsda/misc_utils.py. I'm more an observer than a reviewer when it comes to these details. It's a good learning experience for me. Thanks!
|
Thanks @RussTreadon-NOAA , I have pushed a new commit that dismissed your approval, if @aerorahul is happy with my new changes, I will merge this in once I have one 'approval' |
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me.
* Add r2d2 config * Add ulimit -s unlimited to module
This PR adds a new ush script,
run_single_atm_var_analysis.py.This script does the following:
ush/genYAMLexpectsAlong with this script, the associated functions have been added/modified to support each of the above steps.
A sample input YAML:
To run:
Sample working directory can be found at:
/work2/noaa/stmp/cmartin/gdas_single_test