Add more CI to GW-CI by DavidNew-NOAA · Pull Request #1365 · NOAA-EMC/GDASApp

DavidNew-NOAA · 2024-11-08T12:44:41Z

This PR is a companion to GW PR #3120.

It does a couple things:

5 GW CI tests are added/extended as CTests in GDASApp, running through to the fcst jobs in the first full-cycle. These CI tests are: C96C48_hybatmDA, C96C48_ufs_hybatmDA, C96C48_hybatmaerosnowDA, C48mx500_3DVarAOWCDA, and C48mx500_hybAOWCDA.
Test references are added for C96C48_ufs_hybatmDA and C48mx500_3DVarAOWCDA, so that we're actually testing the output.
These CTests are turned on by default in a workflow build, rather than having to mess with the CMakeCache.txt file and re-running make. This will allow us to use these tests in nightly testing.
test/gw-ci/CMakeLists.txt is refactored quite a bit.
There are 89 CTests, but for 5 CI tests, but I added task dependencies, so they can be run in parallel.

The primary motivation for this PR is that we can run CI for our nightly testing of GDASApp. Also, anyone with a PR can easily do CI testing through CTests.

This reverts commit e024564.

DavidNew-NOAA · 2024-11-24T19:11:15Z

@CoryMartin-NOAA @RussTreadon-NOAA @danholdaway @guillaumevernieres

OK, I think this PR is now ready for final review and merger.

I made some additional changes:

C48mx500_3DVarAOWCDA now has a test reference for marineanlvar
I added CTest dependencies for the atm_jjob tests so they can be run in parallel.
The locations of test references and test output files in GDASApp are centralized (test/testreference and build/gdas/test/testoutput respectively) to make updating references a bit easier. This mimics what the various JEDI repos do.
I removed the old jediinc2fv3jedi.py script (which meant to delete a long time ago) and removed its CTest. I also removed the standalone CTest for gdas_fv3jedi_fv3inc.x since that application already tested twice in the atm_jjob and CI tests.
The nightly testing scripts will use 12 processors to run the CTests to take advantage of the new ability to parallelize the tests.

guillaumevernieres

Thanks @DavidNew-NOAA , looks good.

danholdaway

Thanks @DavidNew-NOAA. How long does it take to run all the ctests now? Not including the code building?

DavidNew-NOAA · 2024-11-25T15:19:57Z

@danholdaway Let me run them all one more time to give you an exact answer

DavidNew-NOAA · 2024-11-25T15:35:11Z

Let me run the test_gdasapp tests one more time, just for certainty. Then I'll merge

DavidNew-NOAA · 2024-11-25T18:02:18Z

I broke something somewhere, causing all test_gdasapp tests to fail. working on it

This reverts commit b1ae4d2.

This reverts commit 0302bee.

DavidNew-NOAA · 2024-11-26T03:53:01Z

@danholdaway My last run of the 119 test_gdasapp CTests took 1 hour and 23 minutes

shlyaeva · 2024-12-02T23:33:28Z

+    set(pslot "GFSv17-3DVAR-C384mx025")
+    set(YAML_PATH ${HOMEgfs}/ci/cases/gfsv17/${pslot}.yaml)


I am trying to run this set of tests, and it can't find the GFSv17-3DVAR-C384mx025.yaml in global-workflow/ci/cases/gfsv17. I don't see this file on develop, and I don't see it in NOAA-EMC/global-workflow#3120. What am I missing? (I have not yet tried to run with NOAA-EMC/global-workflow#3120)

@shlyaeva Yeah, that was a mistake on my part. I assumed the GFSv17 test name had the same naming convention as the low resolution marine CI. Thanks for pointing this out, I'll make a bugfix PR tomorrow morning.

Oh good, thank you for the clarification! I am still figuring out how to run things, so I wasn't sure whether I missed something.

…est (#3120) This PR is a companion to NOAA-EMC/GDASApp#1365 It turns ```C96C48_ufs_hybatmDA``` and ```C48mx500_3DVarAOWCDA``` into a regression test using the JEDI application testing feature. This feature is turned on using the new ```DO_TEST_MODE``` parameter added to ```config.base``` in GW PR [#3115](#3115). This parameter is set to ```"YES"``` in the yaml defaults for the JEDI-based CI tests in GW. The motivation for this PR is a need to catch changes in JEDI which alter the outputs of our applications. --------- Co-authored-by: CoryMartin-NOAA <cory.r.martin@noaa.gov> Co-authored-by: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>

…est (#3120) This PR is a companion to #1365 It turns ```C96C48_ufs_hybatmDA``` and ```C48mx500_3DVarAOWCDA``` into a regression test using the JEDI application testing feature. This feature is turned on using the new ```DO_TEST_MODE``` parameter added to ```config.base``` in GW PR [#3115](NOAA-EMC/global-workflow#3115). This parameter is set to ```"YES"``` in the yaml defaults for the JEDI-based CI tests in GW. The motivation for this PR is a need to catch changes in JEDI which alter the outputs of our applications. --------- Co-authored-by: CoryMartin-NOAA <cory.r.martin@noaa.gov> Co-authored-by: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>

This PR is a companion to [#1365](#1365). It adds test reference blocks to the YAMLs for the JEDI-to-FV3 increment converters.

This PR is a companion to GW PR [#3120](NOAA-EMC/global-workflow#3120). It does a couple things: 1. 5 GW CI tests are added/extended as CTests in GDASApp, running through to the fcst jobs in the first full-cycle. These CI tests are: ```C96C48_hybatmDA```, ```C96C48_ufs_hybatmDA```, ```C96C48_hybatmaerosnowDA```, ```C48mx500_3DVarAOWCDA```, and ```C48mx500_hybAOWCDA```. 2. Test references are added for ```C96C48_ufs_hybatmDA``` and ```C48mx500_3DVarAOWCDA```, so that we're actually testing the output. 3. These CTests are turned on by default in a workflow build, rather than having to mess with the ```CMakeCache.txt``` file and re-running make. This will allow us to use these tests in nightly testing. 4. ```test/gw-ci/CMakeLists.txt``` is refactored quite a bit. 5. There are 89 CTests, but for 5 CI tests, but I added task dependencies, so they can be run in parallel. The primary motivation for this PR is that we can run CI for our nightly testing of GDASApp. Also, anyone with a PR can easily do CI testing through CTests. --------- Co-authored-by: Russ-Treadon-NOAA <Russ.Treadon@noaa.gov>

RussTreadon-NOAA and others added 30 commits October 14, 2024 20:05

point at NOAA-EMC saber bugfix/wcoss2

68c1a45

replace DELP with delp

97cf270

point at NOAA-EMC fv3-jedi patch/fv3-jedi

8f36daa

Merge branch 'develop' into patch/saber

34e8596

Revert "JCB-based obs+bias staging (#1312)"

c7ea876

This reverts commit e024564.

update .gitmodules to point at NOAA-EMC fv3-jedi branch patch/fv3-jedi

c33fbab

Merge branch 'develop' into patch/gwci

0325836

Merge branch 'develop' at f1222ec into patch/gwci

764f58c

Initial commit

88af2ab

Update

80d3280

Forgot a test

984ea31

Add beginning of testing infrastucture to JCB

b270c60

Polishing up

97cfa2b

polishing

e4357c4

Change RUN_GW_CI to WORKFLOW_TESTS

d0f0b80

Add JEDI test references for gw-ci

3652f9a

Update

2473cec

Update jcb-gdas hash

e144bc8

Merge branch 'develop' into feature/gw-ci

26e5aa1

Update git modules

e63ab3f

Merge branch 'develop' into feature/gw-ci

6c2e245

Update yamls

972dd93

Update hashes

08fe673

Revert .gitmodules to develop

be8919a

More reverting

79c4eb9

More reverting

ebb7654

Merge branch 'develop' into feature/gw-ci

9472b1e

Coding norms and test references

086f696

Coding norms

60b39d4

Fix recentering in GSI CI

e8465d2

DavidNew-NOAA added 3 commits November 24, 2024 16:48

Update

93fbcfe

Update

6cac185

Hopefully final commit

5ef43b7

Run gw-ci tests in parallel for nightly testing

cb672bf

DavidNew-NOAA requested review from CoryMartin-NOAA, danholdaway and guillaumevernieres November 25, 2024 13:41

CoryMartin-NOAA reviewed Nov 25, 2024

View reviewed changes

guillaumevernieres previously approved these changes Nov 25, 2024

View reviewed changes

danholdaway previously approved these changes Nov 25, 2024

View reviewed changes

Address comments

0302bee

DavidNew-NOAA dismissed stale reviews from danholdaway and guillaumevernieres via 0302bee November 25, 2024 15:32

Redo setting on ntasks for tests

b1ae4d2

DavidNew-NOAA added 3 commits November 25, 2024 20:12

Revert "Redo setting on ntasks for tests"

0ff6174

This reverts commit b1ae4d2.

Revert "Address comments"

27ac65f

This reverts commit 0302bee.

Readdress comments

a857a8f

CoryMartin-NOAA approved these changes Nov 25, 2024

View reviewed changes

DavidNew-NOAA merged commit 7a01c5e into develop Nov 25, 2024

DavidNew-NOAA deleted the feature/gw-ci branch November 25, 2024 23:35

shlyaeva reviewed Dec 2, 2024

View reviewed changes

DavidNew-NOAA added a commit that referenced this pull request Jan 6, 2026

Add more CI to GW-CI (#42)

2ae0f84

This PR is a companion to [#1365](#1365). It adds test reference blocks to the YAMLs for the JEDI-to-FV3 increment converters.

		set(pslot "GFSv17-3DVAR-C384mx025")
		set(YAML_PATH ${HOMEgfs}/ci/cases/gfsv17/${pslot}.yaml)

Conversation

DavidNew-NOAA commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DavidNew-NOAA commented Nov 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guillaumevernieres left a comment

Choose a reason for hiding this comment

Uh oh!

danholdaway left a comment

Choose a reason for hiding this comment

Uh oh!

DavidNew-NOAA commented Nov 25, 2024

Uh oh!

DavidNew-NOAA commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DavidNew-NOAA commented Nov 25, 2024

Uh oh!

DavidNew-NOAA commented Nov 26, 2024

Uh oh!

shlyaeva Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

DavidNew-NOAA Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

shlyaeva Dec 3, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DavidNew-NOAA commented Nov 8, 2024 •

edited

Loading

DavidNew-NOAA commented Nov 24, 2024 •

edited

Loading

DavidNew-NOAA commented Nov 25, 2024 •

edited

Loading